bpo-40025: Require _generate_next_value_ to be defined before members by abbyonstott · Pull Request #19098 · python/cpython

abbyonstott · 2020-03-21T05:15:27Z

https://bugs.python.org/issue40025

ethanfurman

Please add a note in the docs about _generate_next_value_ needing to be defined before any members are.

bedevere-bot · 2020-03-21T06:23:34Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

tirkarthi · 2020-03-21T07:58:47Z

Could this also have a test about the order raising TypeError?

abbyonstott · 2020-03-21T15:53:38Z

I have made the requested changes; please review again

bedevere-bot · 2020-03-21T15:53:41Z

Thanks for making the requested changes!

@ethanfurman: please review the changes made to this pull request.

ethanfurman

Getting closer -- thank you for persevering!

bedevere-bot · 2020-03-22T05:13:37Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

abbyonstott · 2020-03-22T16:48:43Z

I have made the requested changes; please review again

bedevere-bot · 2020-03-22T16:48:46Z

Thanks for making the requested changes!

@ethanfurman: please review the changes made to this pull request.

ethanfurman

Looking good! A couple minor changes and we should be good to go.

bedevere-bot · 2020-03-29T22:03:01Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

abbyonstott · 2020-03-30T02:53:28Z

I have made the requested changes; please review again

bedevere-bot · 2020-03-30T02:53:32Z

Thanks for making the requested changes!

@ethanfurman: please review the changes made to this pull request.

miss-islington · 2020-04-28T17:22:12Z

Thanks @ethanonstott for the PR, and @ethanfurman for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington · 2020-04-28T17:22:12Z

Thanks @ethanonstott for the PR, and @ethanfurman for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

bedevere-bot · 2020-04-28T17:22:45Z

GH-19762 is a backport of this pull request to the 3.7 branch.

…pythonGH-19098) require `_generate_next_value_` to be defined before members (cherry picked from commit d9a43e2) Co-authored-by: Ethan Onstott <storm@stormprograms.com>

bedevere-bot · 2020-04-28T17:22:55Z

GH-19763 is a backport of this pull request to the 3.8 branch.

Require _generate_next_value_ to be defined before members

b09b148

abbyonstott requested a review from ethanfurman as a code owner March 21, 2020 05:15

the-knights-who-say-ni added the CLA signed label Mar 21, 2020

bedevere-bot added the awaiting review label Mar 21, 2020

blurb-it Bot and others added 2 commits March 21, 2020 05:26

📜🤖 Added by blurb_it.

f74f34e

add name to ACKS

b8c1358

ethanfurman requested changes Mar 21, 2020

View reviewed changes

Comment thread Lib/enum.py Outdated

bedevere-bot removed the awaiting review label Mar 21, 2020

bedevere-bot added the awaiting changes label Mar 21, 2020

abbyonstott added 4 commits March 21, 2020 10:51

Evaluate self._member_names for truthiness

20b0ba3

Specify when _generate_next_value_ must be defined

186953c

Add test for TypeError raised on incorrect order

a386b25

Fix whitespace

6e15316

bedevere-bot removed the awaiting changes label Mar 21, 2020

bedevere-bot added the awaiting change review label Mar 21, 2020

bedevere-bot requested a review from ethanfurman March 21, 2020 15:53

ethanfurman requested changes Mar 22, 2020

View reviewed changes

Comment thread Misc/NEWS.d/next/Library/2020-03-21-05-26-38.bpo-40025.DTLtyq.rst Outdated

Comment thread Lib/enum.py

bedevere-bot added awaiting changes and removed awaiting change review labels Mar 22, 2020

abbyonstott added 2 commits March 22, 2020 11:41

Specify which error is raised

28094cf

Add auto_called attribute to _EnumDict

c1057d3

bedevere-bot added awaiting change review and removed awaiting changes labels Mar 22, 2020

ethanfurman requested changes Mar 29, 2020

View reviewed changes

Comment thread Lib/enum.py Outdated

Comment thread Lib/enum.py Outdated

bedevere-bot added awaiting changes and removed awaiting change review labels Mar 29, 2020

Always set self._auto_called to True

8ad99d2

bedevere-bot added awaiting change review and removed awaiting changes labels Mar 30, 2020

bedevere-bot requested a review from ethanfurman March 30, 2020 02:53

ethanfurman approved these changes Apr 28, 2020

View reviewed changes

Comment thread Lib/enum.py

bedevere-bot added awaiting merge and removed awaiting change review labels Apr 28, 2020

ethanfurman merged commit d9a43e2 into python:master Apr 28, 2020

bedevere-bot removed the awaiting merge label Apr 28, 2020

ethanfurman self-assigned this Apr 28, 2020

ethanfurman added needs backport to 3.7 labels Apr 28, 2020

bedevere-bot removed the needs backport to 3.7 label Apr 28, 2020

bedevere-bot removed the needs backport to 3.8 label Apr 28, 2020

Uh oh!

Uh oh!

Conversation

abbyonstott commented Mar 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ethanfurman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bedevere-bot commented Mar 21, 2020

Uh oh!

tirkarthi commented Mar 21, 2020

Uh oh!

abbyonstott commented Mar 21, 2020

Uh oh!

bedevere-bot commented Mar 21, 2020

Uh oh!

ethanfurman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

bedevere-bot commented Mar 22, 2020

Uh oh!

abbyonstott commented Mar 22, 2020

Uh oh!

bedevere-bot commented Mar 22, 2020

Uh oh!

ethanfurman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

bedevere-bot commented Mar 29, 2020

Uh oh!

abbyonstott commented Mar 30, 2020

Uh oh!

bedevere-bot commented Mar 30, 2020

Uh oh!

Uh oh!

miss-islington commented Apr 28, 2020

Uh oh!

miss-islington commented Apr 28, 2020

Uh oh!

bedevere-bot commented Apr 28, 2020

Uh oh!

bedevere-bot commented Apr 28, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

abbyonstott commented Mar 21, 2020 •

edited

Loading