bpo-40045: Make "dunder" method documentation easier to locate#19153
Merged
Conversation
ghost
changed the title
aeros
approved these changes
Mar 25, 2020
aeros
left a comment
aeros
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR @JavadMokhtari; LGTM.
nanjekyejoannah
approved these changes
Mar 26, 2020
Contributor
There was a problem hiding this comment.
Since there was consensus from bpo here : https://bugs.python.org/issue40045, this LGTM. Thanks for your contribution @JavadMokhtari .
Some minor consistent line length changes
Contributor
|
IMO, this should be backported to 3.8 and 3.7. |
nanjekyejoannah
left a comment
nanjekyejoannah
left a comment
Contributor
There was a problem hiding this comment.
Let us give @rhettinger time to look. If he doesn't, I will merge this tomorrow.
Contributor
|
Thanks @JavadMokhtari for the PR, and @nanjekyejoannah for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
|
@nanjekyejoannah: Please replace |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 27, 2020
…nGH-19153) * issue 40045 * Update lexical_analysis.rst Make "dunder" method documentation easier(pythonGH-19153) Co-authored-by: Joannah Nanjekye <33177550+nanjekyejoannah@users.noreply.github.com> (cherry picked from commit 5f9c131) Co-authored-by: Javad Mokhtari <javadmokhtari@outlook.com>
|
GH-19198 is a backport of this pull request to the 3.8 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 27, 2020
…nGH-19153) * issue 40045 * Update lexical_analysis.rst Make "dunder" method documentation easier(pythonGH-19153) Co-authored-by: Joannah Nanjekye <33177550+nanjekyejoannah@users.noreply.github.com> (cherry picked from commit 5f9c131) Co-authored-by: Javad Mokhtari <javadmokhtari@outlook.com>
|
GH-19199 is a backport of this pull request to the 3.7 branch. |
Contributor
|
Congrats on your first merged CPython PR, @JavadMokhtari! :-) |
nanjekyejoannah
pushed a commit
that referenced
this pull request
Mar 27, 2020
) (GH-19198) * issue 40045 * Update lexical_analysis.rst Make "dunder" method documentation easier(GH-19153) Co-authored-by: Joannah Nanjekye <33177550+nanjekyejoannah@users.noreply.github.com> (cherry picked from commit 5f9c131) Co-authored-by: Javad Mokhtari <javadmokhtari@outlook.com> Co-authored-by: Javad Mokhtari <javadmokhtari@outlook.com>
nanjekyejoannah
pushed a commit
that referenced
this pull request
Mar 27, 2020
) (GH-19199) * issue 40045 * Update lexical_analysis.rst Make "dunder" method documentation easier(GH-19153) Co-authored-by: Joannah Nanjekye <33177550+nanjekyejoannah@users.noreply.github.com> (cherry picked from commit 5f9c131) Co-authored-by: Javad Mokhtari <javadmokhtari@outlook.com> Co-authored-by: Javad Mokhtari <javadmokhtari@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue 40045
https://bugs.python.org/issue40045