bpo-40091: Fix a hang at fork in the logging module#19416
Merged
Conversation
Fix a hang at fork in the logging module: the new private _at_fork_reinit() method is now used to reinitialize locks at fork in the child process. The createLock() method is no longer used at fork.
Member
Author
vsajip
added
the
🔨 test-with-buildbots
bedevere-bot
removed
the
🔨 test-with-buildbots
vsajip
approved these changes
Apr 12, 2020
vsajip
left a comment
vsajip
left a comment
Member
There was a problem hiding this comment.
Looks OK to me, but I'll add gps as a reviewer in case he spots anything.
Member
Author
|
@gpshead: Your request is still welcomed! I merged this PR since test_threading is still crashing randomly on AIX which spams my inbox :-) Recent example: https://buildbot.python.org/all/#builders/227/builds/628 If more changes are required, we can still adjust the code later. |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a hang at fork in the logging module: the new private
_at_fork_reinit() method is now used to reinitialize locks at fork in
the child process.
The createLock() method is no longer used at fork.
https://bugs.python.org/issue40091