bpo-40352: Try to reconnect socket when send message in SocketHandler.#22061
Closed
serhiy-storchaka wants to merge 1 commit into
Closed
bpo-40352: Try to reconnect socket when send message in SocketHandler.#22061serhiy-storchaka wants to merge 1 commit into
serhiy-storchaka wants to merge 1 commit into
Conversation
serhiy-storchaka
added
needs backport to 3.8
type-bug
vsajip
reviewed
Sep 3, 2020
| self.sock = None # so we can call createSocket next time | ||
| if attempt: | ||
| continue | ||
| break |
Member
There was a problem hiding this comment.
IIUC, this code will retry connection once, straight away, if the handler was previously connected but an error occurs when actually sending the event. In the case where the reason for the error is that the remote has gone offline, how likely is that reconnection attempt to succeed? Isn't the remote going offline for a period the case described in the issue?
Contributor
|
This missed the boat for inclusion in Python 3.9 which accepts security fixes only as of today. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO: Tests and NEWS.
https://bugs.python.org/issue40352