Skip to content

No need to test "istep==1" twice. #24064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rhettinger merged 1 commit into from
Jan 2, 2021
Merged

No need to test "istep==1" twice. #24064

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions Lib/random.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,9 +351,9 @@ def randrange(self, start, stop=None, step=_ONE):
DeprecationWarning, 2)
raise ValueError("non-integer step for randrange()")
width = istop - istart
if istep == 1 and width > 0:
return istart + self._randbelow(width)
if istep == 1:
if width > 0:
return istart + self._randbelow(width)
raise ValueError("empty range for randrange() (%d, %d, %d)" % (istart, istop, width))

# Non-unit step argument supplied.
Expand All @@ -363,10 +363,8 @@ def randrange(self, start, stop=None, step=_ONE):
n = (width + istep + 1) // istep
else:
raise ValueError("zero step for randrange()")

if n <= 0:
raise ValueError("empty range for randrange()")

return istart + istep * self._randbelow(n)

def randint(self, a, b):
Expand Down