Skip to content

Fix various ParamSpec errors in typing #24176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miss-islington merged 3 commits into from
Jan 11, 2021
Merged

Fix various ParamSpec errors in typing #24176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9045a28
Paramspec -> typevar
Fidget-Spinner Jan 9, 2021
65c17cb
paramspec isn't actually keyword only
Fidget-Spinner Jan 9, 2021
bb58480
enforce keyword only arguments
Fidget-Spinner Jan 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Doc/library/typing.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -695,10 +695,10 @@ These can be used as types in annotations using ``[]``, each having a unique syn

from collections.abc import Callable
from threading import Lock
from typing import Any, Concatenate, ParamSpec
from typing import Any, Concatenate, ParamSpec, TypeVar

P = ParamSpec('P')
R = ParamSpec('R')
R = TypeVar('R')

# Use this lock to ensure that only one thread is executing a function
# at any time.
Expand Down
2 changes: 1 addition & 1 deletion Lib/typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -779,7 +779,7 @@ def add_two(x: float, y: float) -> float:
args = object()
kwargs = object()

def __init__(self, name, bound=None, covariant=False, contravariant=False):
def __init__(self, name, *, bound=None, covariant=False, contravariant=False):
self.__name__ = name
super().__init__(bound, covariant, contravariant)
try:
Expand Down