Skip to content

bpo-43251: sqlite3_column_name() failures now raise MemoryError#24609

Merged
berkerpeksag merged 9 commits into
python:masterfrom
erlend-aasland:bpo-43251
Feb 28, 2021
Merged

bpo-43251: sqlite3_column_name() failures now raise MemoryError#24609
berkerpeksag merged 9 commits into
python:masterfrom
erlend-aasland:bpo-43251

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Feb 21, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@erlend-aasland

erlend-aasland commented Feb 21, 2021

Copy link
Copy Markdown
Contributor Author

@serhiy-storchaka would you mind reviewing this?

I'm wondering if we should also add some explanatory comments in the source code. What do you think?

serhiy-storchaka
serhiy-storchaka requested changes Feb 21, 2021
View reviewed changes
Comment thread Modules/_sqlite/cursor.c
Comment thread Modules/_sqlite/cursor.c
Comment thread Modules/_sqlite/cursor.c Outdated
@bedevere-bot

bedevere-bot commented Feb 21, 2021

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Erlend Egeberg Aasland and others added 3 commits February 21, 2021 22:21
@serhiy-storchaka
Fix ref leak
7084fc8 
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@serhiy-storchaka
Fix ref. leak
edc1845 
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Address review: Remove unneeded NULL check in _pysqlite_build_column_…
4d4cda8 
…name
@erlend-aasland

erlend-aasland commented Feb 21, 2021

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again

@bedevere-bot

bedevere-bot commented Feb 21, 2021

Copy link
Copy Markdown

Thanks for making the requested changes!

@serhiy-storchaka: please review the changes made to this pull request.

serhiy-storchaka
serhiy-storchaka reviewed Feb 21, 2021
View reviewed changes
Comment thread Modules/_sqlite/cursor.c Outdated
Comment thread Modules/_sqlite/cursor.c Outdated
Comment thread Modules/_sqlite/cursor.c Outdated
@erlend-aasland

erlend-aasland commented Feb 21, 2021

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again

@bedevere-bot

bedevere-bot commented Feb 21, 2021

Copy link
Copy Markdown

Thanks for making the requested changes!

@serhiy-storchaka: please review the changes made to this pull request.

berkerpeksag
berkerpeksag approved these changes Feb 28, 2021
View reviewed changes

@berkerpeksag berkerpeksag left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Serhiy's comments have been addressed and I haven't spotted anything else (refleaks etc.)

@berkerpeksag berkerpeksag merged commit 2183d06 into python:master Feb 28, 2021
@erlend-aasland erlend-aasland deleted the bpo-43251 branch February 28, 2021 17:25
@erlend-aasland

erlend-aasland commented Feb 28, 2021

Copy link
Copy Markdown
Contributor Author

LGTM! Serhiy's comments have been addressed and I haven't spotted anything else (refleaks etc.)

Thank you, @berkerpeksag 🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@berkerpeksag berkerpeksag berkerpeksag approved these changes
@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@erlend-aasland @bedevere-bot @berkerpeksag @serhiy-storchaka @the-knights-who-say-ni