bpo-43752: Fix sqlite3 regression for zero-sized blobs with converters#25228
Merged
Conversation
added 2 commits
April 6, 2021 21:14
felixxm
approved these changes
Apr 6, 2021
felixxm
left a comment
felixxm
left a comment
Contributor
There was a problem hiding this comment.
@erlend-aasland Thanks 🚀 I was close 😉 I can confirm that this patch works for us.
Contributor
Author
Hope you didn't mind me "stealing" the PR, but I immediately knew which commit this had to be :) Appreciate your report with a clear test case. |
Contributor
All good, thanks for fixing this 👍 I'm not really familiar with Python internals, but always eager to contribute 🤓 |
erlend-aasland
commented
Apr 7, 2021
berkerpeksag
approved these changes
Apr 14, 2021
Contributor
Author
|
Thanks for reviewing, @berkerpeksag! |
erlend-aasland
commented
Apr 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue43752