Skip to content

bpo-43434: Clean up after GH-25818#25823

Merged
zooba merged 1 commit into
python:masterfrom
erlend-aasland:cleanup
May 2, 2021
Merged

bpo-43434: Clean up after GH-25818#25823
zooba merged 1 commit into
python:masterfrom
erlend-aasland:cleanup

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented May 2, 2021

Copy link
Copy Markdown
Contributor

@erlend-aasland

Copy link
Copy Markdown
Contributor Author

cc. @zooba

@zooba zooba added the skip news label May 2, 2021

@zooba zooba left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not require backporting, as the backport of the original issue has the changes already applied.

Whoever merges should make the commit message a little more detailed.

@erlend-aasland

Copy link
Copy Markdown
Contributor Author

Thanks, @zooba. How about "Remove variable and if statement made redundant in GH-25818"

BTW, the macOS test failure is unrelated (spurious ssl failure).

@zooba zooba merged commit cbb7b9e into python:master May 2, 2021
@zooba

zooba commented May 2, 2021

Copy link
Copy Markdown
Member

I think having a reference to the function that was changed will be more helpful for searching later.

@erlend-aasland erlend-aasland deleted the cleanup branch May 2, 2021 22:20
@erlend-aasland

Copy link
Copy Markdown
Contributor Author

Good point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants