bpo-44017: Update test_contextlib_async not to emit DeprecationWarn#25918
Merged
Conversation
corona10
requested review from
tirkarthi
and removed request for
1st1,
gvanrossum and
ilevkivskyi
May 5, 2021 16:21
corona10
force-pushed
the
bpo-44017
branch
2 times, most recently
from
May 5, 2021 16:26
36347b2 to
3b6a1b7
Compare
Member
Author
|
@tirkarthi Since I am not asyncio expert, please let me know if I miss something :) |
Member
Author
|
The CI failure is not related to this change |
Contributor
|
I'm not best placed to review asyncio-related changes. |
cjw296
removed their request for review
May 6, 2021 06:16
Member
Author
Ah sorry, I miss-clicked you :( |
serhiy-storchaka
approved these changes
May 6, 2021
Member
Author
|
@serhiy-storchaka Thank you Serhiy! |
This was referenced May 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue44017