Skip to content

bpo-44061: Fix pkgutil.iter_modules regression#25964

Merged
zooba merged 6 commits into
python:mainfrom
miguendes:bpo-44061
May 11, 2021
Merged

bpo-44061: Fix pkgutil.iter_modules regression#25964
zooba merged 6 commits into
python:mainfrom
miguendes:bpo-44061

Conversation

@miguendes

@miguendes miguendes commented May 7, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

zooba
zooba reviewed May 7, 2021
View reviewed changes
Comment thread Lib/test/test_pkgutil.py Outdated
@AnnaStepakova AnnaStepakova mentioned this pull request May 8, 2021
Merged
zooba
zooba reviewed May 10, 2021
View reviewed changes
Comment thread Lib/test/test_pkgutil.py Outdated
zooba
zooba reviewed May 11, 2021
View reviewed changes

@zooba zooba left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor test tweaks, and once applied I'll make sure CI runs and then it should be good.

Comment thread Lib/test/test_pkgutil.py Outdated
Comment thread Lib/test/test_pkgutil.py Outdated
Comment thread Misc/NEWS.d/next/Library/2021-05-07-08-39-23.bpo-44061.MvElG6.rst Outdated
miguendes and others added 3 commits May 11, 2021 18:40
@miguendes @zooba
Update Lib/test/test_pkgutil.py
7743718 
Co-authored-by: Steve Dower <steve.dower@microsoft.com>
@miguendes @zooba
Update Lib/test/test_pkgutil.py
3582959 
Co-authored-by: Steve Dower <steve.dower@microsoft.com>
@miguendes @zooba
Update Misc/NEWS.d/next/Library/2021-05-07-08-39-23.bpo-44061.MvElG6.rst
91cae78 
Co-authored-by: Steve Dower <steve.dower@microsoft.com>
@zooba zooba merged commit e9d7f88 into python:main May 11, 2021
@miss-islington

miss-islington commented May 11, 2021

Copy link
Copy Markdown
Contributor

Thanks @miguendes for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington

miss-islington commented May 11, 2021

Copy link
Copy Markdown
Contributor

Sorry, @miguendes and @zooba, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker e9d7f88d5643f7e6387bf994c130503766d7eb92 3.9

zooba pushed a commit to zooba/cpython that referenced this pull request May 11, 2021
@miguendes @zooba
bpo-44061: Fix pkgutil.iter_modules regression when passed a pathlib.…
7655c85 
…Path object (pythonGH-25964)
@bedevere-bot

bedevere-bot commented May 11, 2021

Copy link
Copy Markdown

GH-26052 is a backport of this pull request to the 3.9 branch.

@miss-islington

miss-islington commented May 12, 2021

Copy link
Copy Markdown
Contributor

Thanks @miguendes for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington

miss-islington commented May 12, 2021

Copy link
Copy Markdown
Contributor

Sorry @miguendes and @zooba, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker e9d7f88d5643f7e6387bf994c130503766d7eb92 3.8

ambv pushed a commit that referenced this pull request May 12, 2021
@zooba @miguendes
bpo-44061: Fix pkgutil.iter_modules regression when passed a pathlib.…
0cb9775 
…Path object (GH-25964) (GH-26052)

Co-authored-by: Miguel Brito <5544985+miguendes@users.noreply.github.com>
ambv pushed a commit to ambv/cpython that referenced this pull request May 12, 2021
@miguendes @ambv
[3.8] bpo-44061: Fix pkgutil.iter_modules regression when passed a pa…
f8f2b10 
…thlib.Path object (pythonGH-25964).

(cherry picked from commit e9d7f88)

Co-authored-by: Miguel Brito <5544985+miguendes@users.noreply.github.com>
@bedevere-bot

bedevere-bot commented May 12, 2021

Copy link
Copy Markdown

GH-26056 is a backport of this pull request to the 3.8 branch.

ambv added a commit that referenced this pull request May 12, 2021
@ambv @miguendes
[3.8] bpo-44061: Fix pkgutil.iter_modules regression when passed a pa…
4844abd 
…thlib.Path object (GH-25964). (GH-26056)

(cherry picked from commit e9d7f88)

Co-authored-by: Miguel Brito <5544985+miguendes@users.noreply.github.com>
@rikardnordgren rikardnordgren mannequin mentioned this pull request May 12, 2022
Closed
facebook-github-bot pushed a commit to facebookincubator/cinder that referenced this pull request Jan 3, 2024
@itamaro @facebook-github-bot
bpo-44061: Fix pkgutil.iter_modules regression when passed a pathlib.…
f46f8e4 
…Path object (GH-25964)

Summary:
upstream issue: python/cpython#88227
upstream PR: python/cpython#25964
upstream commit: python/cpython@e9d7f88

Reviewed By: carljm

Differential Revision: D52495633

fbshipit-source-id: b6d1b3dab4a66d63e4a0171542b236a663b3d6fb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zooba zooba zooba left review comments

Assignees

@zooba zooba

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@miguendes @miss-islington @bedevere-bot @zooba @ambv @the-knights-who-say-ni