bpo-44129: Add descriptive global variables for general purpose bit f…#26118
Merged
Conversation
…lags Replace hex flag masks with named global variables to improve readability. eg. if flags & 0x800 becomes: if flags & _MASK_UTF_FILENAME
FFY00
approved these changes
May 24, 2021
|
This PR is stale because it has been open for 30 days with no activity. |
Member
|
@iritkatriel, could you look at this? 😊 |
Member
|
@serhiy-storchaka and @Yhg1s are listed as zipfile experts. |
github-actions
Bot
removed
the
stale
Contributor
Author
|
Thanks for your help everyone! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…lags
Replace hex flag masks with named global variables to improve
readability.
eg.
if flags & 0x800
becomes:
if flags & _MASK_UTF_FILENAME
https://bugs.python.org/issue44129