bpo-31028: Fix test_pydoc when run directly#2864
Merged
Merged
Conversation
Fix get_pydoc_link() of test_pydoc to fix "./python Lib/test/test_pydoc.py": get the absolute path to __file__ to prevent relative directories.
Member
|
the tests pass on my laptop @serhiy-storchaka |
| "Returns a documentation web link of a module" | ||
| dirname = os.path.dirname | ||
| basedir = dirname(dirname(__file__)) | ||
| basedir = dirname(dirname(os.path.abspath(__file__))) |
Member
There was a problem hiding this comment.
os.path.abspath() doesn't work correctly if the path contains a symlink following by "..".
I would use either os.path.join(os.path.dirname(__file__), os.pardir) or dirname(dirname(os.path.realpath(__file__))).
Member
Author
|
@serhiy-storchaka: "I would use either Ok, I changed my PR to use realpath(). |
serhiy-storchaka
approved these changes
Jul 27, 2017
|
GH-2910 is a backport of this pull request to the 3.6 branch. |
|
GH-2911 is a backport of this pull request to the 2.7 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix get_pydoc_link() of test_pydoc to fix "./python
Lib/test/test_pydoc.py": get the absolute path to file to prevent
relative directories.
https://bugs.python.org/issue31028