bpo-45561: Run smelly.py tool from $(srcdir) (GH-29138)#29138
Merged
Conversation
nascheme
force-pushed
the
srcdir_smelly
branch
from
373212a to
e82ed4c
Compare
|
This PR is stale because it has been open for 30 days with no activity. |
nascheme
force-pushed
the
srcdir_smelly
branch
from
e82ed4c to
f6bd560
Compare
Member
Author
|
Someone fixed the multissltests.py test but smelly.py is still run from wrong path (if building from separate dir). |
nascheme
changed the title
Member
I did. Looks like we ran into the same problem. |
tiran
approved these changes
Nov 23, 2021
tiran
changed the title
Contributor
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 23, 2021
(cherry picked from commit 457e6a6) Co-authored-by: Neil Schemenauer <nas-github@arctrix.com>
|
GH-29719 is a backport of this pull request to the 3.10 branch. |
Member
|
Oh, I missed this PR. I didn't test it, but thanks for the fix :-) |
miss-islington
added a commit
that referenced
this pull request
Nov 23, 2021
remykarem
pushed a commit
to remykarem/cpython
that referenced
this pull request
Dec 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue45561