Skip to content

bpo-27062: add __all__ to inspect module#30003

Merged
ambv merged 3 commits into
python:mainfrom
kumaraditya303:issue27062
Dec 10, 2021
Merged

bpo-27062: add __all__ to inspect module#30003
ambv merged 3 commits into
python:mainfrom
kumaraditya303:issue27062

Conversation

@kumaraditya303

@kumaraditya303 kumaraditya303 commented Dec 9, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

iritkatriel
iritkatriel reviewed Dec 9, 2021
View reviewed changes
Comment thread Lib/inspect.py Outdated
tiran
tiran previously requested changes Dec 9, 2021
View reviewed changes

@tiran tiran left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changeset needs a test to verify that __all__ does not regress.

Comment thread Lib/inspect.py Outdated
@bedevere-bot

bedevere-bot commented Dec 9, 2021

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

asvetlov
asvetlov previously requested changes Dec 9, 2021
View reviewed changes

@asvetlov asvetlov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

__all__ is for public API.
Parameter, Signature, and BoundArguments should be enumerated along with other names.

iritkatriel
iritkatriel reviewed Dec 9, 2021
View reviewed changes
Comment thread Lib/test/test_inspect.py Outdated
@kumaraditya303

kumaraditya303 commented Dec 9, 2021

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again

@bedevere-bot

bedevere-bot commented Dec 9, 2021

Copy link
Copy Markdown

Thanks for making the requested changes!

@asvetlov, @tiran: please review the changes made to this pull request.

AlexWaygood
AlexWaygood reviewed Dec 9, 2021
View reviewed changes
Comment thread Lib/inspect.py Outdated
@ambv ambv dismissed stale reviews from asvetlov and tiran December 10, 2021 23:04

Review addressed

@ambv ambv merged commit 810c176 into python:main Dec 10, 2021
@kumaraditya303 kumaraditya303 deleted the issue27062 branch December 11, 2021 07:58
aisk
aisk reviewed Dec 13, 2021
View reviewed changes
Comment thread Lib/inspect.py
__author__ = ('Ka-Ping Yee <ping@lfw.org>',
'Yury Selivanov <yselivanov@sprymix.com>')


@aisk aisk Dec 13, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was some invisible spaces here. I think this is not expected.

@AlexWaygood AlexWaygood mentioned this pull request Jan 27, 2022
Closed
@AlexWaygood AlexWaygood mentioned this pull request Jun 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aisk aisk aisk left review comments
@AlexWaygood AlexWaygood AlexWaygood left review comments
@ambv ambv ambv approved these changes
@asvetlov asvetlov Awaiting requested review from asvetlov
@tiran tiran Awaiting requested review from tiran
@iritkatriel iritkatriel Awaiting requested review from iritkatriel

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@kumaraditya303 @bedevere-bot @ambv @asvetlov @tiran @aisk @iritkatriel @AlexWaygood @the-knights-who-say-ni