Skip to content

bpo-28546: Clarify setting pdb breakpoints - #30360

Merged
iritkatriel merged 1 commit into
python:mainfrom
hugovk:issue28546-clarify-pdb-docs
Jan 7, 2022
Merged

bpo-28546: Clarify setting pdb breakpoints#30360
iritkatriel merged 1 commit into
python:mainfrom
hugovk:issue28546-clarify-pdb-docs

Conversation

@hugovk

@hugovk hugovk commented Jan 3, 2022 •
edited by iritkatriel
Loading

Copy link
Copy Markdown
Member

Co-authored-by: Ian Kelling ian@iankelling.org

Converted the 2016 patch at https://bugs.python.org/issue28546 to a GitHub PR.

Same text, except added a comma for clarity.

Documentation PR can skip NEWS entry.

https://bugs.python.org/issue28546

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jan 3, 2022
@iritkatriel

iritkatriel commented Jan 3, 2022

Copy link
Copy Markdown
Member

Thank you. Please credit the author of the original patch with a “coauthored-by” (the dev guide should have an example, but if not I’ll help you look it up.)

@hugovk

hugovk commented Jan 3, 2022

Copy link
Copy Markdown
Member Author

Sure, although I don't know Ian's email address.

https://bugs.python.org/file45253/iank-v1.patch has no author line.

https://bugs.python.org/issue28546 has only "Ian Kelling (iank)".

https://bugs.python.org/user24848 has his email address hidden.

Should I use Co-authored-by: Ian Kelling or something else?

@iritkatriel

iritkatriel commented Jan 3, 2022

Copy link
Copy Markdown
Member

There’s an email here: https://iankelling.org/

@iritkatriel

iritkatriel commented Jan 3, 2022

Copy link
Copy Markdown
Member

I see the same email on bpo, so it’s the same person.

@hugovk @ian-kelling
bpo-28546: Clarify setting pdb breakpoints
0b9c9ae 
Co-authored-by: Ian Kelling <ian@iankelling.org>
@hugovk
hugovk force-pushed the issue28546-clarify-pdb-docs branch from 67d2013 to 0b9c9ae Compare January 3, 2022 17:17
@hugovk

hugovk commented Jan 3, 2022

Copy link
Copy Markdown
Member Author

Thanks, updated!

@iritkatriel
iritkatriel merged commit 6d07a9f into python:main Jan 7, 2022
@miss-islington

miss-islington commented Jan 7, 2022

Copy link
Copy Markdown
Contributor

Thanks @hugovk for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 7, 2022
@hugovk @miss-islington
bpo-28546: [doc] Clarify setting pdb breakpoints (pythonGH-30360)
f172d04 
Co-authored-by: Ian Kelling <ian@iankelling.org>
(cherry picked from commit 6d07a9f)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@bedevere-bot

bedevere-bot commented Jan 7, 2022

Copy link
Copy Markdown

GH-30464 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jan 7, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 7, 2022
@hugovk @miss-islington
bpo-28546: [doc] Clarify setting pdb breakpoints (pythonGH-30360)
ea86ba8 
Co-authored-by: Ian Kelling <ian@iankelling.org>
(cherry picked from commit 6d07a9f)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@bedevere-bot

bedevere-bot commented Jan 7, 2022

Copy link
Copy Markdown

GH-30465 is a backport of this pull request to the 3.9 branch.

@hugovk
hugovk deleted the issue28546-clarify-pdb-docs branch January 7, 2022 19:53
miss-islington added a commit that referenced this pull request Jan 7, 2022
@miss-islington @hugovk
bpo-28546: [doc] Clarify setting pdb breakpoints (GH-30360)
ed2656a 
Co-authored-by: Ian Kelling <ian@iankelling.org>
(cherry picked from commit 6d07a9f)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Jan 7, 2022
@miss-islington @hugovk
bpo-28546: [doc] Clarify setting pdb breakpoints (GH-30360)
a74eb54 
Co-authored-by: Ian Kelling <ian@iankelling.org>
(cherry picked from commit 6d07a9f)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@hugovk @iritkatriel @miss-islington @bedevere-bot @the-knights-who-say-ni @AlexWaygood