bpo-46471: use global singletons for single byte bytes objects#30781
Merged
Conversation
gvanrossum
approved these changes
Jan 22, 2022
gvanrossum
left a comment
gvanrossum
left a comment
Member
There was a problem hiding this comment.
How many of these do you see in deepfreeze.c? Singletons byte literals aren’t that common I guess.
Contributor
Author
❯ cat Python/deepfreeze/deepfreeze.c | grep "(PyObject \*)&_Py_SINGLETON(bytes_characters" | wc -l
200 |
raghavthind2005
approved these changes
Jan 23, 2022
gvanrossum
approved these changes
Jan 23, 2022
gvanrossum
left a comment
gvanrossum
left a comment
Member
There was a problem hiding this comment.
Ah, I see. co_localspluskinds is a bytes object (flags for args and local vars) and when there's exactly one of those, it qualifies. Clever.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By using global singletons for single byte bytes objects in deepfreeze, there is no need to generate c code for it so it reduces the size of generated c file and reduces memory use of the objects when they are allocated on the heap as now they are statically allocated and they are already immortal.
https://bugs.python.org/issue46471