Update importlib.abc hierarchy#31113
Merged
Merged
Conversation
Fixed some inconsistencies in the text about relationships
hugovk
approved these changes
Feb 10, 2022
hugovk
left a comment
hugovk
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR, looks good.
The diagram currently looks like:
And the text says for both MetaPathFinder and PathEntryFinder:
Changed in version 3.10: No longer a subclass of
Finder.
https://docs.python.org/3/library/importlib.html
And code agrees:
class Finder(metaclass=abc.ABCMeta):
...
class MetaPathFinder(metaclass=abc.ABCMeta):
...
class PathEntryFinder(metaclass=abc.ABCMeta):So it makes sense to update the digram to show they're no longer subclasses of something about to be removed.
Here's how it looks in the PR:
JelleZijlstra
approved these changes
May 2, 2022
Contributor
|
Thanks @davidgilbertson for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 2, 2022
Fixed some inconsistencies in the text about relationships (cherry picked from commit 5f45a9d) Co-authored-by: David Gilbertson <gilbertson.david@gmail.com>
|
GH-92189 is a backport of this pull request to the 3.10 branch. |
miss-islington
added a commit
that referenced
this pull request
May 2, 2022
Fixed some inconsistencies in the text about relationships (cherry picked from commit 5f45a9d) Co-authored-by: David Gilbertson <gilbertson.david@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed some inconsistencies in the text about relationships.
I know nothing about the implementation, I'm just aligning the page with itself; apologies if this is not right.