Skip to content

bpo-46429: tweak deepfreeze output#32107

Merged
gvanrossum merged 5 commits into
python:mainfrom
kumaraditya303:tweak-deepfreeze
Mar 27, 2022
Merged

bpo-46429: tweak deepfreeze output#32107
gvanrossum merged 5 commits into
python:mainfrom
kumaraditya303:tweak-deepfreeze

Conversation

@kumaraditya303

@kumaraditya303 kumaraditya303 commented Mar 25, 2022

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue46429

  • Generates better names for locals
  • Generates better names for ints

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t like the new macro. It hides things I’d like to see clearly. The const_str thing is nice though.

Comment thread Tools/scripts/deepfreeze.py Outdated
Comment thread Tools/scripts/deepfreeze.py Outdated
Comment thread Tools/scripts/deepfreeze.py Outdated
Comment thread Tools/scripts/deepfreeze.py Outdated
Comment thread Tools/scripts/deepfreeze.py Outdated
Comment thread Tools/scripts/deepfreeze.py Outdated

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@gvanrossum gvanrossum merged commit 785cc67 into python:main Mar 27, 2022
@bedevere-bot

Copy link
Copy Markdown

@gvanrossum: Please replace # with GH- in the commit message next time. Thanks!

@kumaraditya303 kumaraditya303 deleted the tweak-deepfreeze branch March 27, 2022 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants