Skip to content

Stop test_xmlrpc from writing to sys.stderr#3359

Merged
tiran merged 1 commit into
python:masterfrom
tiran:silence_test_xmlrpc
Sep 6, 2017
Merged

Stop test_xmlrpc from writing to sys.stderr#3359
tiran merged 1 commit into
python:masterfrom
tiran:silence_test_xmlrpc

Conversation

@tiran

@tiran tiran commented Sep 5, 2017

Copy link
Copy Markdown
Member

One test case of test_xmlrpc uses HTTPServer with a subclass of
BaseHTTPRequestHandler. The BaseRequestHandler class logs to
sys.stderr by default. Override log_message() to not clobber
test output.

Signed-off-by: Christian Heimes christian@python.org

@tiran
Stop test_xmlrpc from writing to sys.stderr
933cecc 
One test case of test_xmlrpc uses HTTPServer with a subclass of
BaseHTTPRequestHandler. The BaseRequestHandler class logs to
sys.stderr by default. Override log_message() to not clobber
test output.

Signed-off-by: Christian Heimes <christian@python.org>
@tiran tiran added needs backport to 3.6 tests Tests in the Lib/test dir labels Sep 5, 2017
@vstinner

vstinner commented Sep 5, 2017

Copy link
Copy Markdown
Member

We are talking about these two lines:

127.0.0.1 - - [06/Sep/2017 01:39:46] "POST / HTTP/1.1" 200 -
127.0.0.1 - - [06/Sep/2017 01:39:46] "POST / HTTP/1.1" 200 -

from

haypo@selma$ ./python -m test test_xmlrpc
Run tests sequentially
0:00:00 load avg: 0.47 [1/1] test_xmlrpc
127.0.0.1 - - [06/Sep/2017 01:39:46] "POST / HTTP/1.1" 200 -
127.0.0.1 - - [06/Sep/2017 01:39:46] "POST / HTTP/1.1" 200 -
1 test OK.

Total duration: 4 sec
Tests result: SUCCESS

vstinner
vstinner approved these changes Sep 5, 2017
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I tested manually that it fixes the issue.

@tiran tiran merged commit 3463ee3 into python:master Sep 6, 2017
@miss-islington

miss-islington commented Sep 6, 2017

Copy link
Copy Markdown
Contributor

🐍🍒⛏🤖 Thanks @tiran for the PR, and @tiran for merging it 🌮🎉.I'm working now to backport this PR to: 3.6.

@tiran tiran deleted the silence_test_xmlrpc branch September 6, 2017 04:43
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 6, 2017
@tiran @miss-islington
[3.6] Stop test_xmlrpc from writing to sys.stderr (pythonGH-3359)
2d00575 
One test case of test_xmlrpc uses HTTPServer with a subclass of
BaseHTTPRequestHandler. The BaseRequestHandler class logs to
sys.stderr by default. Override log_message() to not clobber
test output.

Signed-off-by: Christian Heimes <christian@python.org>
(cherry picked from commit 3463ee3)
@bedevere-bot

bedevere-bot commented Sep 6, 2017

Copy link
Copy Markdown

GH-3380 is a backport of this pull request to the 3.6 branch.

rhettinger pushed a commit that referenced this pull request Sep 6, 2017
@miss-islington @rhettinger
[3.6] Stop test_xmlrpc from writing to sys.stderr (GH-3359) (#3380)
3aea3c2 
One test case of test_xmlrpc uses HTTPServer with a subclass of
BaseHTTPRequestHandler. The BaseRequestHandler class logs to
sys.stderr by default. Override log_message() to not clobber
test output.

Signed-off-by: Christian Heimes <christian@python.org>
(cherry picked from commit 3463ee3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Labels

skip issue skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tiran @vstinner @miss-islington @bedevere-bot @Mariatta @the-knights-who-say-ni