Skip to content

closes bpo-31902: Fix the col_offset attribute for ast.Async* nodes to point to the "async" keyword.#4175

Merged
miss-islington merged 4 commits into
python:masterfrom
guoci:col_offset_async_nodes
Sep 11, 2018
Merged

closes bpo-31902: Fix the col_offset attribute for ast.Async* nodes to point to the "async" keyword.#4175
miss-islington merged 4 commits into
python:masterfrom
guoci:col_offset_async_nodes

Conversation

@guoci

@guoci guoci commented Oct 30, 2017 •
edited by benjaminp
Loading

Copy link
Copy Markdown
Contributor

Previously, col_offset points to the keyword after "async".

@guoci guoci changed the title Fix the col_offset attribute for ast.Async* nodes to point to the "as… bpo-29205: Fix the col_offset attribute for ast.Async* nodes to point to the "as… Oct 30, 2017
@guoci guoci changed the title bpo-29205: Fix the col_offset attribute for ast.Async* nodes to point to the "as… bpo-31902: Fix the col_offset attribute for ast.Async* nodes to point to the "as… Oct 30, 2017
benjaminp
benjaminp requested changes Sep 11, 2018
View reviewed changes
Comment thread Python/ast.c Outdated
Comment thread Python/ast.c Outdated
@bedevere-bot

bedevere-bot commented Sep 11, 2018

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@guoci guoci force-pushed the col_offset_async_nodes branch from 2aa5034 to 731fee0 Compare September 11, 2018 20:09
@guoci

guoci commented Sep 11, 2018

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again

@bedevere-bot

bedevere-bot commented Sep 11, 2018

Copy link
Copy Markdown

Thanks for making the requested changes!

@benjaminp: please review the changes made to this pull request.

@benjaminp benjaminp changed the title bpo-31902: Fix the col_offset attribute for ast.Async* nodes to point to the "as… closes bpo-31902: Fix the col_offset attribute for ast.Async* nodes to point to the "async" keyword. Sep 11, 2018
@miss-islington

miss-islington commented Sep 11, 2018

Copy link
Copy Markdown
Contributor

@guoci: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 90fc898 into python:master Sep 11, 2018
@miss-islington

miss-islington commented Sep 11, 2018

Copy link
Copy Markdown
Contributor

Thanks @guoci for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 11, 2018
@guoci @miss-islington
closes bpo-31902: Fix the col_offset attribute for ast.Async* nodes t…
d6675e5 
…o point to the "async" keyword. (pythonGH-4175)

Previously, col_offset points to the keyword after "async".
(cherry picked from commit 90fc898)

Co-authored-by: guoci <zguoci@gmail.com>
@bedevere-bot

bedevere-bot commented Sep 11, 2018

Copy link
Copy Markdown

GH-9188 is a backport of this pull request to the 3.7 branch.

@miss-islington

miss-islington commented Sep 11, 2018

Copy link
Copy Markdown
Contributor

Sorry, @guoci, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 90fc8980bbcc5c7dcced3627fe172b0bfd193a3b 3.6

@miss-islington miss-islington self-assigned this Sep 11, 2018
miss-islington added a commit that referenced this pull request Sep 11, 2018
@miss-islington @guoci
closes bpo-31902: Fix the col_offset attribute for ast.Async* nodes t…
d8bc7a6 
…o point to the "async" keyword. (GH-4175)

Previously, col_offset points to the keyword after "async".
(cherry picked from commit 90fc898)

Co-authored-by: guoci <zguoci@gmail.com>
@guoci guoci deleted the col_offset_async_nodes branch May 10, 2021 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjaminp benjaminp benjaminp approved these changes

Assignees

@miss-islington miss-islington

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@guoci @bedevere-bot @miss-islington @benjaminp @the-knights-who-say-ni