Skip to content

bpo-32440: Use HTTPS in help()#5030

Merged
Mariatta merged 1 commit into
python:masterfrom
oldk1331:bpo-32440
Dec 28, 2017
Merged

bpo-32440: Use HTTPS in help()#5030
Mariatta merged 1 commit into
python:masterfrom
oldk1331:bpo-32440

Conversation

@oldk1331

@oldk1331 oldk1331 commented Dec 28, 2017 •
edited by asvetlov
Loading

Copy link
Copy Markdown
Contributor

@the-knights-who-say-ni

the-knights-who-say-ni commented Dec 28, 2017

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@Mariatta Mariatta merged commit e5681b9 into python:master Dec 28, 2017
@miss-islington

miss-islington commented Dec 28, 2017

Copy link
Copy Markdown
Contributor

Thanks @oldk1331 for the PR, and @Mariatta for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 28, 2017
@oldk1331 @miss-islington
bpo-32440: Update the docs URL to https in help() (pythonGH-5030)
c34304d 
In pydoc.py, the reference to Python' documentation was in http.
The link has been updated to use https.
(cherry picked from commit e5681b9)
@bedevere-bot

bedevere-bot commented Dec 28, 2017

Copy link
Copy Markdown

GH-5031 is a backport of this pull request to the 3.6 branch.

@Mariatta

Mariatta commented Dec 28, 2017

Copy link
Copy Markdown
Member

Thanks @oldk1331 and congrats on your first contribution to CPython 🌮

@Mariatta

Mariatta commented Dec 28, 2017

Copy link
Copy Markdown
Member

I consider this a trivial change, so the CLA is not necessary. However, please sign it for your future contributions. Thanks.

Mariatta pushed a commit that referenced this pull request Dec 28, 2017
@miss-islington @Mariatta
bpo-32440: Update the docs URL to https in help() (GH-5030) (GH-5031)
6eb232c 
In pydoc.py, the reference to Python' documentation was in http.
The link has been updated to use https.
(cherry picked from commit e5681b9)
freddrake pushed a commit that referenced this pull request Mar 26, 2021
@miss-islington @jpsutton
bpo-43620: Remove reference to os.sep from os.path.join() doc (GH-25025…
455583b 
…, GH-5030)

- removed ambiguous reference to os.sep from os.path.join() doc
(cherry picked from commit 21a2cab)

Co-authored-by: Jared Sutton <jpsutton@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mariatta Mariatta Mariatta approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@oldk1331 @the-knights-who-say-ni @miss-islington @bedevere-bot @Mariatta @asvetlov