Skip to content

bpo-32701: Fix typo in quopri documentation.#5401

Merged
Mariatta merged 1 commit into
python:masterfrom
JulienPalard:bpo-32701
Jan 30, 2018
Merged

bpo-32701: Fix typo in quopri documentation.#5401
Mariatta merged 1 commit into
python:masterfrom
JulienPalard:bpo-32701

Conversation

@JulienPalard

@JulienPalard JulienPalard commented Jan 28, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@Mariatta

Mariatta commented Jan 28, 2018

Copy link
Copy Markdown
Member

Looks good, thanks! Since you're a core dev now, please merge when you're ready 😄

@Mariatta

Mariatta commented Jan 29, 2018

Copy link
Copy Markdown
Member

You can apply the skip news and needs backport to 3.6 labels.

orsenthil
orsenthil approved these changes Jan 29, 2018
View reviewed changes

@orsenthil orsenthil left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

I found the module docstring succinct. That could be adopted if you feel it is better.

 The 'quotetabs' flag indicates whether embedded tabs and spaces should be quoted.

@Mariatta Mariatta self-assigned this Jan 30, 2018
@Mariatta

Mariatta commented Jan 30, 2018

Copy link
Copy Markdown
Member

@JulienPalard If it's ok with you, I'd like to use this PR to test out if miss-islington correctly adds the Co-authored-by: footer in the backport, so I'll merge this myself.

@Mariatta Mariatta merged commit 9424dcb into python:master Jan 30, 2018
@miss-islington

miss-islington commented Jan 30, 2018

Copy link
Copy Markdown
Contributor

Thanks @JulienPalard for the PR, and @Mariatta for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 30, 2018
@JulienPalard @miss-islington
bpo-32701: Clarify the quotetabs flag in quopri documentation (python…
af78af4 
…GH-5401)

(cherry picked from commit 9424dcb)

Co-authored-by: Julien Palard <julien@palard.fr>
@bedevere-bot

bedevere-bot commented Jan 30, 2018

Copy link
Copy Markdown

GH-5438 is a backport of this pull request to the 3.6 branch.

Mariatta pushed a commit that referenced this pull request Jan 30, 2018
@miss-islington @JulienPalard @Mariatta
bpo-32701: Clarify the quotetabs flag in quopri documentation (GH-5401)…
04f99ba 
… (GH-5438)

(cherry picked from commit 9424dcb)

Co-authored-by: Julien Palard <julien@palard.fr>
@Mariatta Mariatta removed their assignment Jun 10, 2018
@JulienPalard JulienPalard deleted the bpo-32701 branch June 16, 2019 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@orsenthil orsenthil orsenthil approved these changes
@Mariatta Mariatta Mariatta approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@JulienPalard @Mariatta @miss-islington @bedevere-bot @orsenthil @the-knights-who-say-ni