Skip to content

bpo-33169: Remove values of None from sys.path_importer_cache when invalidating caches#6402

Merged
brettcannon merged 5 commits into
python:masterfrom
brettcannon:invalidate-caches-None
Apr 6, 2018
Merged

bpo-33169: Remove values of None from sys.path_importer_cache when invalidating caches#6402
brettcannon merged 5 commits into
python:masterfrom
brettcannon:invalidate-caches-None

Conversation

@brettcannon

@brettcannon brettcannon commented Apr 6, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

An entry of None in sys.path_importer_cache represents a negative/missing finder for a path.

https://bugs.python.org/issue33169

@brettcannon brettcannon merged commit 9e2be60 into python:master Apr 6, 2018
@miss-islington

miss-islington commented Apr 6, 2018

Copy link
Copy Markdown
Contributor

Thanks @brettcannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@brettcannon brettcannon deleted the invalidate-caches-None branch April 6, 2018 23:10
@miss-islington

miss-islington commented Apr 6, 2018

Copy link
Copy Markdown
Contributor

Sorry, @brettcannon, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 9e2be60634914f23db2ae5624e4acc9335bf5fea 3.7

brettcannon added a commit to brettcannon/cpython that referenced this pull request Apr 6, 2018
@brettcannon
[3.7] bpo-33169: Remove values of None from sys.path_importer_cache…
ab9b245 
… when invalidating caches (pythonGH-6402)

An entry of None in sys.path_importer_cache represents a negative/missing finder for a path, so clearing it out makes sense..
(cherry picked from commit 9e2be60)

Co-authored-by: Brett Cannon <brettcannon@users.noreply.github.com>
@bedevere-bot

bedevere-bot commented Apr 6, 2018

Copy link
Copy Markdown

GH-6403 is a backport of this pull request to the 3.7 branch.

brettcannon added a commit that referenced this pull request Apr 7, 2018
@brettcannon
[3.7] bpo-33169: Remove values of None from sys.path_importer_cache…
a09bb87 
… when invalidating caches (GH-6402) (GH-6403)

An entry of None in sys.path_importer_cache represents a negative/missing finder for a path, so clearing it out makes sense.
(cherry picked from commit 9e2be60)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@brettcannon @miss-islington @bedevere-bot @the-knights-who-say-ni