gh-76595: PyCapsule_Import() now imports submodules if needed.#6898
gh-76595: PyCapsule_Import() now imports submodules if needed.#6898serhiy-storchaka wants to merge 5 commits into
Conversation
|
Do you plan to add tests, or are you OK leaving that to someone else? |
|
Currently there are no any tests for PyCapsule. I'm going to write them if possible, but this will take a time. |
|
I'm asking because writing tests would make a nice task for mentoring someone – but it would take even more time that way. |
| if (object) { | ||
| PyObject *object2 = PyObject_GetAttrString(object, trace); | ||
| Py_DECREF(object); | ||
| object = object2; |
There was a problem hiding this comment.
Yes, it can be used here.
| if (no_block) { | ||
| object = PyImport_ImportModuleNoBlock(name_dup); | ||
| } else { | ||
| object = PyImport_ImportModule(name_dup); |
There was a problem hiding this comment.
aren't PyImport_ImportModuleNoBlock and PyImport_ImportModule the same thing now?
| Py_DECREF(object); | ||
| object = object2; | ||
| if (object) { | ||
| Py_SETREF(object, PyObject_GetAttrString(object, trace)); |
There was a problem hiding this comment.
I would expect error handling here, if PyObject_GetAttrString() fails for whatever reason. It seems like PyImport_ImportModule() is tried on the substring on error.
|
When you're done making the requested changes, leave the comment: |
|
@serhiy-storchaka, it looks like this one was close to being merged, so just putting it back on the radar. |
|
This PR is stale because it has been open for 30 days with no activity. |
|
I have a use case for this and would be happy to rebase / take over from @serhiy-storchaka if you don't have the time for it |
github-actions
Bot
removed
the
stale
|
This PR is stale because it has been open for 30 days with no activity. |
picnixz
changed the title
github-actions
Bot
removed
the
stale
|
This PR is stale because it has been open for 30 days with no activity. |
There's a PR (pythonGH-6898) which changes this behavior (to be less surprising, I believe), but this seems to have stalled. See: python#76595 See: python#6898
10 participants
https://bugs.python.org/issue32414