bpo-34127: Fix grammar in error message with respect to argument count#8395
Conversation
|
Raymond, you merged this just before I tried to submit a review suggesting changes and expansion to include all the fixes needed in the file. I cannot submit the review and AFAIK, cannot turn pending review comments into regular comments, so I am copying most of them here before before cancelling the review. Tests: In the 3 tests before this, the suffix 0, 2, or 3 is the number of arguments given. This would suggest 0a, 0b, 2a, and 3a for the suffixes here. I like 1min, 2min, 1max, and 2max even better. You can wait a bit for other reviews before changing. Blurb: Let us be more specific. For the patch as is, But if we add all the remaining fixes needed in this file (see below), we could write. Fixes: This patch follows existing expressions formatted into argument%s: Scope: I think we should finish the job in the file. The next line in both else clauses, Fixes for the following will break some test, which will then need fixing also. I checked all PyErr_Format entries and did not see anything other than %d arguments and %d elements. |
|
@terryjreedy Thanks much for the comments. Since the current issue was closed I will open a new one as I get home in a couple of hours with the above comment as a continuation of work. |
test_call.pybased on the changes made.https://bugs.python.org/issue34127