Skip to content

[2.7] bpo-25750: fix refcounts in type_getattro() (GH-6118)#9089

Closed
miss-islington wants to merge 1 commit into
python:2.7from
miss-islington:backport-8f73548-2.7
Closed

[2.7] bpo-25750: fix refcounts in type_getattro() (GH-6118)#9089
miss-islington wants to merge 1 commit into
python:2.7from
miss-islington:backport-8f73548-2.7

Conversation

@miss-islington

@miss-islington miss-islington commented Sep 7, 2018

Copy link
Copy Markdown
Contributor

When calling tp_descr_get(self, obj, type), make sure that
we own a strong reference to "self".
(cherry picked from commit 8f73548)

Co-authored-by: jdemeyer jdemeyer@cage.ugent.be

https://bugs.python.org/issue25750

When calling tp_descr_get(self, obj, type), make sure that
we own a strong reference to "self".
(cherry picked from commit 8f73548)

Co-authored-by: jdemeyer <jdemeyer@cage.ugent.be>

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot 🤖!

@miss-islington

Copy link
Copy Markdown
Contributor Author

@jdemeyer and @vstinner: Backport status check is done, and it's a failure ❌ .

@vstinner

vstinner commented Sep 7, 2018

Copy link
Copy Markdown
Member

ISO C89 forbids mixed declaration and code. I wrote PR #9091 to move the "descrgetfunc local_get;" declaration.

@vstinner vstinner closed this Sep 7, 2018
@miss-islington miss-islington deleted the backport-8f73548-2.7 branch September 7, 2018 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants