gh-94598: Remove deprecated ssl modules features#94599
Conversation
|
ae51bdc to
cfe4777
Compare
|
Can you make these attributes warn on access in 3.11? using the approach here Lines 28 to 38 in 6dadf6c Currently they only warn at use, and it would make testing this change much easier if they warn on access |
|
Enum's convert helper gets in the way. It adds the variables to global name space unconditionally. |
|
Could you |
|
That's ugly. |
|
It's ugly but it would give users a heads-up this is going to be removed. |
The ssl module has been warning about deprecated features since 3.10: Functions and methods don't warn on attribute access either. They typically warn when they are called (used). |
|
Compromise: 3.11 is at the end of its beta phase. I don't want to add ugly code to it. Instead I'm going to add warnings for the deprecated module constants to 3.12 and remove them in 3.13. They won't work in 3.12, though. Attribute access won't raise an AttributeError. |
| sslsocket_class = None # SSLSocket is assigned later. | ||
| sslobject_class = None # SSLObject is assigned later. | ||
|
|
||
| def __new__(cls, protocol=None, *args, **kwargs): |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Is there any chance to get it into 3.12b1? |
Feel free to pick it up and prepare it for the next 3.13 alpha. |
|
This PR is stale because it has been open for 30 days with no activity. |
Uh oh!
There was an error while loading. Please reload this page.