Skip to content

gh-94309: Update "What's New for Python 3.12"#94729

Merged
Fidget-Spinner merged 5 commits into
python:mainfrom
MonadChains:gh-94309/update-whats-new
Jul 14, 2022
Merged

gh-94309: Update "What's New for Python 3.12"#94729
Fidget-Spinner merged 5 commits into
python:mainfrom
MonadChains:gh-94309/update-whats-new

Conversation

@MonadChains

@MonadChains MonadChains commented Jul 10, 2022

Copy link
Copy Markdown
Contributor

@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir labels Jul 10, 2022
Comment thread Doc/whatsnew/3.12.rst Outdated
:keyword:`for`, :keyword:`if`, :keyword:`in`, :keyword:`is` and :keyword:`or`.
In a future release it will be changed to a syntax error. (:gh:`87999`)
* :class:`typing.Hashable` and :class:`typing.Sized` aliases for :class:`collections.abc.Hashable`
and :class:`collections.abc.Sized`. (:gh:`94309`)

@hugovk hugovk Jul 11, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's group it with the other typing deprecation. Please could you move it up, something like this? Thanks!

The following APIs were deprecated in earlier Python versions and will be removed,
although there is currently no date scheduled for their removal.

* :class:`typing.Hashable` and :class:`typing.Sized` aliases for :class:`collections.abc.Hashable`
  and :class:`collections.abc.Sized`. (:gh:`94309`)

* :class:`typing.Text` (:gh:`92332`)

* Currently Python accepts numeric literals immediately followed by keywords,

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Comment thread Doc/whatsnew/3.12.rst Outdated
Comment thread Doc/whatsnew/3.12.rst
Comment on lines 193 to -191


Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry. I tried removing the extra blank line but removed one line extra. Could you please add back a newline?

@JelleZijlstra

Copy link
Copy Markdown
Member

I'm not sure I'm on board with "will be removed". Deprecated and discouraged, sure, but I don't see much reason to ever actually remove them.

@hugovk

hugovk commented Jul 11, 2022

Copy link
Copy Markdown
Member

@JelleZijlstra Would you like another heading+intro for these two typing bullets?

@MonadChains

Copy link
Copy Markdown
Contributor Author

@JelleZijlstra do you plan to remove the aliases deprecate with PEP 585 in the future? If so, I think that also these aliases should be removed in the future for consistency.

@JelleZijlstra

Copy link
Copy Markdown
Member

I don't want the PEP 585 deprecations removed either. https://discuss.python.org/t/concern-about-pep-585-removals/15901/3?u=jelle

@Fidget-Spinner

Copy link
Copy Markdown
Member

Woops yeah I forgot that these have no planned removal date.

@MonadChains

Copy link
Copy Markdown
Contributor Author

So should I close the PR?

ps: btw do you have any tips on possible next steps in contributing to Python?

@Fidget-Spinner

Copy link
Copy Markdown
Member

Please don't close the PR. Move the text to under this section:
https://docs.python.org/3.12/whatsnew/3.12.html#deprecated

We did the same in 3.11
https://docs.python.org/3.12/whatsnew/3.11.html#deprecated

@Fidget-Spinner Fidget-Spinner merged commit b03a9e8 into python:main Jul 14, 2022
@Fidget-Spinner

Copy link
Copy Markdown
Member

@MonadChains since you asked earlier about what to contribute to. Apart from easy issues on the issues page, you can try focus on areas that you're interested in or areas you think the most help.

Reviewing PR is also good. However, it may require some expertise in the subject area first. So I recommend working on documentation and eventually learning how things in your favorite area work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants