docs: use 'recursively' in the description of rglob, and mention globs in the os equivalences#94954
Merged
Conversation
…s in the os equivalences
nedbat
added
docs
barneygale
reviewed
Jul 20, 2022
brettcannon
approved these changes
Jul 20, 2022
brettcannon
added
needs backport to 3.10
Contributor
|
Status check is done, and it's a success ✅ . |
Contributor
|
Thanks @nedbat for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
Contributor
|
Sorry @nedbat, I had trouble checking out the |
|
GH-95071 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 20, 2022
…s in the os equivalences (pythonGH-94954) The r in `rglob` stands for "recursively", so use the word in the description. Also, glob and rglob can usefully be mentioned as the pathlib equivalent of os.walk. Automerge-Triggered-By: GH:brettcannon (cherry picked from commit 6e2fbda) Co-authored-by: Ned Batchelder <ned@nedbatchelder.com>
Member
|
@nedbat do you care enough to try and fix the 3.11 backport failure? If you are I can leave the 3.10 PR open for merging. Otherwise I'm also fine making this a 3.12 improvement alone. |
Member
Author
|
Let's just go with 3.12. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The r in
rglobstands for "recursively", so use the word in the description. Also, glob and rglob can usefully be mentioned as the pathlib equivalent of os.walk.Automerge-Triggered-By: GH:brettcannon