gh-95005: Replace PyAccu with PyUnicodeWriter#95006
Conversation
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
PyAccu was still being used in only two places: the JSON encoder and StringIO. Replace PyAccu with PyUnicodeWriter and remove PyAccu completely.
MaxwellDupre
left a comment
There was a problem hiding this comment.
only 3 tests failed from test suite. Code is good.
PyAccu was still being used in only two places: the JSON encoder and StringIO. Replace PyAccu with PyUnicodeWriter and remove PyAccu completely.
Which test? |
|
buildbot/AMD64 Debian seems to have a broken compiler or hardware error. The compiler crashed the last time and now it gets SIGBUS while compiling |
|
I ran |
I sent a mail to the machine owner, seems unrelated to this PR. |
corona10
left a comment
There was a problem hiding this comment.
lgtm
Overall looks good, I just left nit comment.
Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
PyAccu was still being used in only two places: the JSON encoder and StringIO.
Replace PyAccu with PyUnicodeWriter and remove PyAccu completely.