GH-93899: fix checks for eventfd flags

[kumaraditya303]

• Issue: ./configure eventfd support does not also check for existence of flags #93899

Automerge-Triggered-By: GH:tiran

[erlend-aasland]

LGTM, but os_eventfd_impl could also use a wrapper, and some of the tests should skip if these flags are not present.

[bedevere-bot]

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

[kumaraditya303]

but os_eventfd_impl could also use a wrapper,

Added guard to os.eventfd.

and some of the tests should skip if these flags are not present.

The tests are already skipped on older kernel versions.

cpython/Lib/test/test_os.py

Lines 3686 to 3690 in 3c94d33

	@unittest.skipUnless(hasattr(os, 'eventfd'), 'requires os.eventfd')
	@support.requires_linux_version(2, 6, 30)
	class EventfdTests(unittest.TestCase):
	def test_eventfd_initval(self):
	def pack(value):

I have made the requested changes; please review again

[bedevere-bot]

Thanks for making the requested changes!

@erlend-aasland: please review the changes made to this pull request.

[tiran]

If you actually want to support ancient Kernels, then let's use consistent checks.

[bedevere-bot]

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

[erlend-aasland]

LGTM. You may consider to make the NEWS entry a little bit more specific ("older kernel versions" is a bit vague).

[kumaraditya303]

LGTM. You may consider to make the NEWS entry a little bit more specific ("older kernel versions" is a bit vague).

Thanks for the review! I have reworded news entry, should be better now!

[erlend-aasland]

Thanks, I'm fine with that. I'll land it as soon as the CI is green and I get a final approval from @tiran. Thanks!

[miss-islington]

Thanks @kumaraditya303 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

[miss-islington]

Sorry, @kumaraditya303, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 4dd099bafff14639ef5d2185965016d8f253353f 3.11

[miss-islington]

Sorry @kumaraditya303, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 4dd099bafff14639ef5d2185965016d8f253353f 3.10

[erlend-aasland]

Will you fix the backports, Kumar? It's probably just a clinic regen that's missing. (Can we teach Miss I to do that?)

[bedevere-bot]

GH-95342 is a backport of this pull request to the 3.11 branch.

[bedevere-bot]

GH-95345 is a backport of this pull request to the 3.10 branch.

[kumaraditya303]

Will you fix the backports, Kumar?

Done