Skip to content

bpo-34789: make xml.sax.make_parser accept iterables of all types#9576

Merged
taleinat merged 9 commits into
python:masterfrom
andresdelfino:bpo-34789-make_parser-master
Oct 26, 2018
Merged

bpo-34789: make xml.sax.make_parser accept iterables of all types#9576
taleinat merged 9 commits into
python:masterfrom
andresdelfino:bpo-34789-make_parser-master

Conversation

@andresdelfino

@andresdelfino andresdelfino commented Sep 25, 2018

Copy link
Copy Markdown
Contributor

Comment thread Lib/xml/sax/__init__.py
Comment thread Lib/test/test_sax.py

@taleinat taleinat left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be a great opportunity to change the default value for parser_list from [] to something immutable, e.g. an empty tuple. (Using mutable default values is a Bad Idea™!)

@andresdelfino andresdelfino force-pushed the bpo-34789-make_parser-master branch from b62ac13 to b4cf5bb Compare October 26, 2018 13:43
@andresdelfino

Copy link
Copy Markdown
Contributor Author

@taleinat yes, I think you are right. My last commit addresses this suggestion too.

Comment thread Lib/test/test_sax.py
Comment thread Lib/xml/sax/__init__.py Outdated

@taleinat taleinat left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taleinat taleinat changed the title bpo-34789: make xml.sax.make_parser accept iterables bpo-34789: make xml.sax.make_parser accept any iterable type Oct 26, 2018
@taleinat taleinat changed the title bpo-34789: make xml.sax.make_parser accept any iterable type bpo-34789: make xml.sax.make_parser accept iterables of all types Oct 26, 2018
@miss-islington

Copy link
Copy Markdown
Contributor

@andresdelfino: Status check is done, and it's a failure ❌ .

1 similar comment
@miss-islington

Copy link
Copy Markdown
Contributor

@andresdelfino: Status check is done, and it's a failure ❌ .

@taleinat taleinat merged commit a6dc531 into python:master Oct 26, 2018
@andresdelfino andresdelfino deleted the bpo-34789-make_parser-master branch October 26, 2018 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants