Skip to content

bpo-34476: Document that asyncio.sleep() always suspends.#9643

Merged
asvetlov merged 2 commits into
python:masterfrom
hniksic:bpo-34476
Oct 1, 2018
Merged

bpo-34476: Document that asyncio.sleep() always suspends.#9643
asvetlov merged 2 commits into
python:masterfrom
hniksic:bpo-34476

Conversation

@hniksic

@hniksic hniksic commented Sep 30, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@the-knights-who-say-ni

the-knights-who-say-ni commented Sep 30, 2018

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Sep 30, 2018
asvetlov
asvetlov requested changes Sep 30, 2018
View reviewed changes
Comment thread Doc/library/asyncio-task.rst Outdated
@bedevere-bot

bedevere-bot commented Sep 30, 2018

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@hniksic

hniksic commented Sep 30, 2018

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again.

@bedevere-bot

bedevere-bot commented Sep 30, 2018

Copy link
Copy Markdown

Thanks for making the requested changes!

@asvetlov: please review the changes made to this pull request.

@asvetlov asvetlov merged commit cd602b8 into python:master Oct 1, 2018
@miss-islington

miss-islington commented Oct 1, 2018

Copy link
Copy Markdown
Contributor

Thanks @hniksic for the PR, and @asvetlov for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Oct 1, 2018

Copy link
Copy Markdown

@asvetlov: Please replace # with GH- in the commit message next time. Thanks!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 1, 2018
@hniksic @miss-islington
bpo-34476: Document that asyncio.sleep() always suspends. (pythonGH-9643
43a3848 
)

(cherry picked from commit cd602b8)

Co-authored-by: Hrvoje Nikšić <hniksic@gmail.com>
@bedevere-bot

bedevere-bot commented Oct 1, 2018

Copy link
Copy Markdown

GH-9654 is a backport of this pull request to the 3.7 branch.

@asvetlov

asvetlov commented Oct 1, 2018

Copy link
Copy Markdown
Contributor

@hniksic thank you for your patience.

asvetlov pushed a commit that referenced this pull request Oct 1, 2018
@miss-islington @hniksic @asvetlov
bpo-34476: Document that asyncio.sleep() always suspends. (GH-9643) (#…
655608a 
…9654)

(cherry picked from commit cd602b8)

Co-authored-by: Hrvoje Nikšić <hniksic@gmail.com>
@hniksic

hniksic commented Oct 1, 2018

Copy link
Copy Markdown
Contributor Author

@asvetlov No problem, thanks for the quick reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asvetlov asvetlov asvetlov approved these changes
@1st1 1st1 Awaiting requested review from 1st1

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@hniksic @the-knights-who-say-ni @bedevere-bot @miss-islington @asvetlov @1st1