Skip to content

gh-98602: [typing docs] Use quotes for forward reference in TypeVarTuple example#98605

Merged
AlexWaygood merged 1 commit into
python:mainfrom
Eclips4:main
Oct 25, 2022
Merged

gh-98602: [typing docs] Use quotes for forward reference in TypeVarTuple example#98605
AlexWaygood merged 1 commit into
python:mainfrom
Eclips4:main

Conversation

@Eclips4

@Eclips4 Eclips4 commented Oct 24, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Oct 24, 2022
@ghost

ghost commented Oct 24, 2022 •
edited by ghost
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed

AlexWaygood
AlexWaygood approved these changes Oct 24, 2022
View reviewed changes

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change makes sense to me, at least until either PEP 563 or PEP 649 becomes the default

@AlexWaygood

AlexWaygood commented Oct 25, 2022

Copy link
Copy Markdown
Member

(Cc. @mrahtz)

@AlexWaygood AlexWaygood added the needs backport to 3.11 only security fixes label Oct 25, 2022
@AlexWaygood AlexWaygood changed the title gh-98602: fix return value of __abs__ method in example of TypeVarTuple gh-98602: [typing docs] Use quotes for forward reference in TypeVarTuple example Oct 25, 2022
@AlexWaygood
AlexWaygood merged commit be0cf82 into python:main Oct 25, 2022
@miss-islington

miss-islington commented Oct 25, 2022

Copy link
Copy Markdown
Contributor

Thanks @Eclips4 for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Oct 25, 2022

Copy link
Copy Markdown
Contributor

Sorry @Eclips4 and @AlexWaygood, I had trouble checking out the 3.11 backport branch.
Please retry by removing and re-adding the "needs backport to 3.11" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker be0cf82ae4e49891dcd5e37012d6f6ce08bc4726 3.11

@AlexWaygood AlexWaygood added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels Oct 25, 2022
@miss-islington

miss-islington commented Oct 25, 2022

Copy link
Copy Markdown
Contributor

Thanks @Eclips4 for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Oct 25, 2022

Copy link
Copy Markdown

GH-98669 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Oct 25, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 25, 2022
@Eclips4 @miss-islington
pythongh-98602: [typing docs] Use quotes for forward reference in Typ…
073ffad 
…eVarTuple example (pythonGH-98605)

(cherry picked from commit be0cf82)

Co-authored-by: Eclips4 <80244920+Eclips4@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Oct 25, 2022
@miss-islington @Eclips4
gh-98602: [typing docs] Use quotes for forward reference in TypeVarTu…
4cd5ea6 
…ple example (GH-98605)

(cherry picked from commit be0cf82)

Co-authored-by: Eclips4 <80244920+Eclips4@users.noreply.github.com>
@gvanrossum
gvanrossum removed their request for review October 25, 2022 18:55
@mrahtz

mrahtz commented Oct 26, 2022

Copy link
Copy Markdown
Contributor

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
@AlexWaygood AlexWaygood AlexWaygood approved these changes
@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner

Assignees

@AlexWaygood AlexWaygood

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Eclips4 @AlexWaygood @miss-islington @bedevere-bot @mrahtz @JelleZijlstra