Adopt Ruff#1372
Merged
Merged
Conversation
hugovk
reviewed
Aug 14, 2024
hugovk
left a comment
hugovk
left a comment
Member
There was a problem hiding this comment.
I've set
target-version = "py312"as that is what we have in CPython, but we could lower this requirement if wanted.
I don't mind much, but some others have asked for lower versions before. We don't gain a lot by requiring a higher version, just the datetime thing at the moment, which isn't too much bother.
AA-Turner
commented
Aug 14, 2024
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've set
target-version = "py312"as that is what we have in CPython, but we could lower this requirement if wanted.A
📚 Documentation preview 📚: https://cpython-devguide--1372.org.readthedocs.build/