Skip to content

gh-861: Document GitHub CLI#882

Merged
ezio-melotti merged 11 commits into
python:mainfrom
za:gh-861-document-github-cli
Jul 1, 2022
Merged

gh-861: Document GitHub CLI#882
ezio-melotti merged 11 commits into
python:mainfrom
za:gh-861-document-github-cli

Conversation

@za

@za za commented Jun 6, 2022

Copy link
Copy Markdown
Contributor

Closes #861

Comment thread gitbootcamp.rst Outdated
Comment thread gitbootcamp.rst Outdated
Comment thread gitbootcamp.rst Outdated
Comment thread gitbootcamp.rst Outdated
Comment thread gitbootcamp.rst Outdated
Comment thread gitbootcamp.rst
@za
za marked this pull request as ready for review June 7, 2022 06:53
@za
za requested review from Mariatta and ezio-melotti June 8, 2022 02:52
Comment thread gitbootcamp.rst Outdated
Comment thread gitbootcamp.rst Outdated
@za
za requested a review from ezio-melotti June 9, 2022 06:28
@erlend-aasland erlend-aasland changed the title gh-861 Document GitHub CLI on gitbootcamp.rst gh-861: Document GitHub CLI Jun 9, 2022
@hugovk

hugovk commented Jun 9, 2022

Copy link
Copy Markdown
Member

Tip: you can also see a build preview by clicking "Show all checks" and then Details next to Read the Docs:

image

image

@za

za commented Jun 23, 2022

Copy link
Copy Markdown
Contributor Author

Hi @ezio-melotti once you have the time, can you check the PR again? Thank you.

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions :)

Comment thread gitbootcamp.rst Outdated
Comment thread gitbootcamp.rst Outdated
Comment thread gitbootcamp.rst Outdated
Comment thread gitbootcamp.rst Outdated
Comment thread gitbootcamp.rst Outdated
Comment thread gitbootcamp.rst Outdated
@za

za commented Jun 29, 2022

Copy link
Copy Markdown
Contributor Author

Thanks for the feedback @hugovk . I've addressed them, please check.

@za
za requested a review from hugovk June 29, 2022 07:37
Comment thread gitbootcamp.rst Outdated
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@za
za requested a review from hugovk June 30, 2022 03:19
Comment thread gitbootcamp.rst Outdated
Comment thread gitbootcamp.rst Outdated
@za
za requested review from ezio-melotti and hugovk July 1, 2022 04:08
@ezio-melotti
ezio-melotti merged commit d88bf3a into python:main Jul 1, 2022
@za

za commented Jul 1, 2022

Copy link
Copy Markdown
Contributor Author

Thanks for the review @ezio-melotti @hugovk @Mariatta ! 🎉

@ezio-melotti

Copy link
Copy Markdown
Member

Thanks for the PR!

kitarefake added a commit to kitarefake/devguide that referenced this pull request Jul 15, 2024
* gh-861 Initial commit to document GitHub CLI on gitbootcamp.rst

* gh-861 Address feedback

* Numbered list
* ssh formatting
* code block removal

Reference:
python/devguide#882 (review)

* gh-861 Add <pr-id>

* gh-861 Add short description and installation instruction.

* gh-861 Reformat the hyperlink

* gh-861 Make `gh auth login` in a separate section

and fix the broken link.

* gh-861 Address feedback from @hugovk

python/devguide#882 (review)

* gh-861 Make the period not as part of the hyperlink.

* gh-8161 Change to lowercase

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>

* gh-861 No need to repeat CLI

Feedback by @hugovk
python/devguide#882 (comment)

* gh-861 Simplified introduction paragraph

Feedback by @ezio-melotti
python/devguide#882 (comment)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document GitHub CLI

4 participants