Skip to content
Navigation Menu
Sign in
Appearance settings
Platform
AI CODE CREATION
GitHub Copilot
Write better code with AI
GitHub Copilot app
Direct agents from issue to merge
MCP Registry
Integrate external tools
DEVELOPER WORKFLOWS
Actions
Automate any workflow
Codespaces
Instant dev environments
Issues
Plan and track work
Code Review
Manage code changes
Code Quality
Enforce quality at merge
APPLICATION SECURITY
GitHub Advanced Security
Find and fix vulnerabilities
Code security
Secure your code as you build
Secret protection
Stop leaks before they start
EXPLORE
Why GitHub
Documentation
Blog
Changelog
Marketplace
View all features
Solutions
BY COMPANY SIZE
Enterprises
Small and medium teams
Startups
Nonprofits
BY USE CASE
App Modernization
DevSecOps
DevOps
CI/CD
View all use cases
BY INDUSTRY
Healthcare
Financial services
Manufacturing
Government
View all industries
View all solutions
Resources
EXPLORE BY TOPIC
AI
Software Development
DevOps
Security
View all topics
EXPLORE BY TYPE
Customer stories
Events & webinars
Ebooks & reports
Business insights
GitHub Skills
SUPPORT & SERVICES
Documentation
Customer support
Community forum
Trust center
Partners
View all resources
Open Source
COMMUNITY
GitHub Sponsors
Fund open source developers
PROGRAMS
Security Lab
Maintainer Community
GitHub Stars
Archive Program
REPOSITORIES
Topics
Trending
Collections
Enterprise
ENTERPRISE SOLUTIONS
Enterprise platform
AI-powered developer platform
AVAILABLE ADD-ONS
GitHub Advanced Security
Enterprise-grade security features
Copilot for Business
Enterprise-grade AI features
Premium Support
Enterprise-grade 24/7 support
Pricing
Search
/
Sign in
Sign up
Appearance settings
You signed in with another tab or window.
Reload
to refresh your session.
You signed out in another tab or window.
Reload
to refresh your session.
You switched accounts on another tab or window.
Reload
to refresh your session.
Dismiss alert
{{ message }}
Uh oh!
There was an error while loading.
Please reload this page
.
python
/
importlib_resources
Public
Uh oh!
There was an error while loading.
Please reload this page
.
Notifications
You must be signed in to change notification settings
Fork
49
Star
74
Code
Issues
5
Pull requests
4
Actions
Projects
Security and quality
0
Insights
Additional navigation options
Code
Issues
Pull requests
Actions
Projects
Security and quality
Insights
Release handle on zipfile when generating path in ZipReader
- #194
#194
Merged
jaraco
merged 17 commits into
master
python/importlib_resources:master
from
bugfix/bpo-41490
python/importlib_resources:bugfix/bpo-41490
Copy head branch name to clipboard
Oct 22, 2020
Conversation
Commits
17
(17)
Checks
Files changed
Merged
Release handle on zipfile when generating path in ZipReader
#194
jaraco
merged 17 commits into
master
python/importlib_resources:master
from
bugfix/bpo-41490
python/importlib_resources:bugfix/bpo-41490
Copy head branch name to clipboard
Commits
Commits on Oct 22, 2020
Add test capturing deleting zips. From python/cpython#21748.
jaraco
committed
9992a54
View commit details
Copy full SHA for 9992a54
Browse repository at this point
👹 Feed the hobgoblins (delint).
jaraco
committed
87361b1
View commit details
Copy full SHA for 87361b1
Browse repository at this point
Ensure unlink gets fspath treatment
jaraco
committed
5d047c9
View commit details
Copy full SHA for 5d047c9
Browse repository at this point
Add Python 2.7 compatibility for modules_setup/cleanup
jaraco
committed
922871b
View commit details
Copy full SHA for 922871b
Browse repository at this point
Defer construction of the zipfile.Path and release the handle after grabbing a temporary file. Closes #110.
jaraco
committed
6ab2b58
View commit details
Copy full SHA for 6ab2b58
Browse repository at this point
Try sleeping to see if that gives gc time to clean up and close the zipfile.
jaraco
committed
01a2ed4
View commit details
Copy full SHA for 01a2ed4
Browse repository at this point
Also delete references to reader in _path_from_reader
jaraco
committed
0410114
View commit details
Copy full SHA for 0410114
Browse repository at this point
Also delete the reader in _tempfile
jaraco
committed
e838d1b
View commit details
Copy full SHA for e838d1b
Browse repository at this point
This approach begins to work, but it requires as_file to be aware of the internals of zipfile.Path.
jaraco
committed
f661cb4
View commit details
Copy full SHA for f661cb4
Browse repository at this point
Remove unnecessary context managers.
jaraco
committed
4657df7
View commit details
Copy full SHA for 4657df7
Browse repository at this point
Refactor _path_from_reader to avoid introduction of extraneous context managers.
jaraco
committed
eb8570c
View commit details
Copy full SHA for eb8570c
Browse repository at this point
Skip this test, because it's difficult to achieve.
jaraco
committed
b080948
View commit details
Copy full SHA for b080948
Browse repository at this point
Ignore types on compatibility objects
jaraco
committed
0fae833
View commit details
Copy full SHA for 0fae833
Browse repository at this point
Fix posargs for cov, diffcov
jaraco
committed
f85c3e1
View commit details
Copy full SHA for f85c3e1
Browse repository at this point
Exclude zip files from coverage so Delete tests don't trip up coverage.
jaraco
committed
c929cbc
View commit details
Copy full SHA for c929cbc
Browse repository at this point
Consolidate import_helper functions.
jaraco
committed
9b018ff
View commit details
Copy full SHA for 9b018ff
Browse repository at this point
Update changelog.
jaraco
committed
522f271
View commit details
Copy full SHA for 522f271
Browse repository at this point
You can’t perform that action at this time.