Sync typeshed#1849
Merged
Merged
Conversation
Closed
Member
Author
|
@ddfisher ready when you are... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This time around, syncing typeshed was not easy. I had to push some changes to typeshed (python/typeshed#355) and then make some fixes to mypy itself (contained in this PR). Inspiration for all of this was #1841 but two out of three files changed there were taken care of more pleasantly than the changes there. Only the test_random.py change there (adding a
# type: ignore) is still needed, due to #1846 -- I can't arrive at a simple but correct fix for the latter.