Path to source files added in verbose mode#8536
Merged
Merged
Conversation
Collaborator
|
There are a bunch of test failures. I'll take a look if you fix them. |
akerami
added a commit
to davidzwa/mypy
that referenced
this pull request
Mar 14, 2020
For failing tests of python#8536
akerami
added a commit
to davidzwa/mypy
that referenced
this pull request
Mar 18, 2020
For failing tests of python#8536. For the last push I didn't take into account the result of the runtest file which is why 1 test case (for Travis )was failing.
JukkaL
reviewed
Mar 18, 2020
JukkaL
left a comment
JukkaL
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the PR! I left some comments below.
| src_pth_str += "s" | ||
| configuration_vars.append((src_pth_str, "")) | ||
| for source_path in src_pths: | ||
| configuration_vars.append(("." * len(src_pth_str), source_path)) |
Collaborator
There was a problem hiding this comment.
This looks odd to me. For consistency with other verbose, I think that it would be better to show all source paths on a single line, separated by spaces.
| for source_path in src_pths: | ||
| configuration_vars.append(("." * len(src_pth_str), source_path)) | ||
| elif len(src_pths) == 1: | ||
| configuration_vars.append((src_pth_str, src_pths.copy().pop())) |
Collaborator
There was a problem hiding this comment.
This case will go away once you implement the suggestion above.
| ("Configured Executable", manager.options.python_executable), | ||
| ] | ||
|
|
||
| src_pth_str = "Source Path File" |
Collaborator
There was a problem hiding this comment.
This would clearer if it would be just "Source Path".
Contributor
Author
|
Thanks! I will make the changes. |
akerami
added a commit
to davidzwa/mypy
that referenced
this pull request
Mar 20, 2020
For python#8536 feedback of core team leader is applied to code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of parts of #6544 , namely of printing the path of the source files given to be processed by mypy. Tested using the command line as well as a configuration file.