Add support for using __bool__ method literal value in union narrowing in if statements#9297
Merged
JukkaL merged 2 commits intoAug 14, 2020
Conversation
JukkaL
approved these changes
Aug 14, 2020
JukkaL
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the PR! The code is nice and clean, and there is good test coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for union narrowing in if statements when condition value has defined literal annotations in
__bool__method. Value is narrowed based on the__bool__method return annotation and this works even if multiple instances defines the same literal value for__bool__method return type.This PR also works well with #9288 and makes below example to work as expected:
Partially fixes #9220