Skip to content

PEP 587: PyConfig_InitPythonConfig() cannot fail anymore - #1187

Merged
vstinner merged 1 commit into
python:masterfrom
vstinner:pyconfig_init
Oct 1, 2019
Merged

PEP 587: PyConfig_InitPythonConfig() cannot fail anymore#1187
vstinner merged 1 commit into
python:masterfrom
vstinner:pyconfig_init

Conversation

@vstinner

@vstinner vstinner commented Oct 1, 2019

Copy link
Copy Markdown
Member

PyConfig_InitPythonConfig() and PyConfig_InitIsolatedConfig() no
longer return PyStatus: they cannot fail anymore.

@vstinner
PEP 587: PyConfig_InitPythonConfig() cannot fail anymore
25a15b9 
PyConfig_InitPythonConfig() and PyConfig_InitIsolatedConfig() no
longer return PyStatus: they cannot fail anymore.
@vstinner

vstinner commented Oct 1, 2019

Copy link
Copy Markdown
Member Author

See python/cpython#16509 :

I forgot to update PyConfig_InitPythonConfig() and PyConfig_InitIsolatedConfig() in my PR #16500. There is no more need to return PyStatus since these functions cannot fail anymore. They don't allocate any memory: strings are initialized to NULL, lists to empty lists (which doesn't allocate any memory).

@vstinner

vstinner commented Oct 1, 2019

Copy link
Copy Markdown
Member Author

cc @ncoghlan @ambv

@vstinner
vstinner merged commit 06fbcf5 into python:master Oct 1, 2019
@vstinner
vstinner deleted the pyconfig_init branch October 1, 2019 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vstinner @the-knights-who-say-ni