Skip to content

Update Contributing Guide#561

Merged
skpanagiotis merged 23 commits into
python:mainfrom
skpanagiotis:ft/contributing-guide
Nov 21, 2024
Merged

Update Contributing Guide#561
skpanagiotis merged 23 commits into
python:mainfrom
skpanagiotis:ft/contributing-guide

Conversation

@skpanagiotis

Copy link
Copy Markdown
Collaborator

Ποιο issue κλείνει το συγκεκριμένο PR;

Closes #548

Περιγραφή του PR

Βελτίωση του Contributing Guide για να είναι πιο κατανοητός ο τρόπος που γίνεται συνεισφορά στο έργο της μετάφρασης.

@thepetk thepetk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Κάποια μικρά suggestions αφησα μόνο!

Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md
Comment thread CONTRIBUTING.md Outdated
skpanagiotis and others added 3 commits November 11, 2024 23:22
Co-authored-by: Theofanis Petkos <thepetk@gmail.com>
Co-authored-by: Theofanis Petkos <thepetk@gmail.com>
Co-authored-by: Theofanis Petkos <thepetk@gmail.com>
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
thepetk
thepetk previously approved these changes Nov 18, 2024

@thepetk thepetk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gzisopoulos

Copy link
Copy Markdown
Contributor

Οταν κάνει κάποιος fork ενα repository αυτο εχει προεπιλεγμενο να κάνει copy μονο το main branch. Αν ακολουθησει καποιος τα βηματα με το main branch τοτε όταν κανει pip install -r requirements.txt θα πάρει error γιατι το cpython directory ειναι κενο. Οποτε ισως πρέπει να τους γράψουμε να κανουν fetch πρωτα και checkout στο 3.12 πριν κανουν install τα requirements ή να ξεκλικαρουν το μονο το main branch οταν κανουν fork και να χρειαζονται μονο ενα checkout πριν γινουν install τα requirements.
image

@skpanagiotis

Copy link
Copy Markdown
Collaborator Author

Σωστή αυτή η παρατήρηση @gzisopoulos . Για αυτό πρέπει να γίνει default branch μας το 3.12 αφού γίνει merge με το master.

@gzisopoulos

Copy link
Copy Markdown
Contributor

Επισης το scripts/check_spelling.py είναι στο main branch και δεν υπάρχει στο 3.12 απο το οποιο γινεται το checkout για το καινουριο branch με τη μεταφραση που θα ανεβασει ο χρήστης.

@gmargaritis gmargaritis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Πολύ καλές αλλαγές! Kudos to everyone 🎉

Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
skpanagiotis and others added 6 commits November 20, 2024 09:32
Co-authored-by: George Margaritis <gmargaritis@protonmail.com>
Co-authored-by: George Margaritis <gmargaritis@protonmail.com>
Co-authored-by: George Margaritis <gmargaritis@protonmail.com>
Co-authored-by: George Margaritis <gmargaritis@protonmail.com>
Co-authored-by: George Margaritis <gmargaritis@protonmail.com>
gmargaritis
gmargaritis previously approved these changes Nov 20, 2024

@gmargaritis gmargaritis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@lysnikolaou lysnikolaou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skpanagiotis and everyone, amazing work! Thanks a lot for doing this!

A couple of comments (here and inline):

Can we add a second command to the 4th step of setting up. After git remote add upstream, it'd be best if contributors also did git remote set-url --push upstream git@github.com:<your-username>/cpython.git to avoid accidentally pushing to the upstream repo.

Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
skpanagiotis and others added 5 commits November 20, 2024 15:54
Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
@skpanagiotis skpanagiotis requested a review from a team as a code owner November 20, 2024 15:22
@skpanagiotis

Copy link
Copy Markdown
Collaborator Author

Πρόσθεσα και το extra βήμα του @lysnikolaou

@lysnikolaou lysnikolaou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks everyone!

Comment thread CONTRIBUTING.md Outdated
@lysnikolaou

Copy link
Copy Markdown
Member

Pushed the nitty comment I made above, I think we're good to merge at this point.

@skpanagiotis skpanagiotis enabled auto-merge (squash) November 21, 2024 07:56

@lysnikolaou lysnikolaou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving so that the button turns green.

@lysnikolaou lysnikolaou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving so that the button turns green.

@skpanagiotis skpanagiotis merged commit a39daa7 into python:main Nov 21, 2024
@skpanagiotis skpanagiotis deleted the ft/contributing-guide branch December 16, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Contributing.md after pre-commit addition

6 participants