Skip to content

Translate file library/collections.abc.po#580

Merged
skpanagiotis merged 28 commits into
python:3.12from
mgiannopoulos24:translate/library-collections-abc
Jan 20, 2025
Merged

Translate file library/collections.abc.po#580
skpanagiotis merged 28 commits into
python:3.12from
mgiannopoulos24:translate/library-collections-abc

Conversation

@mgiannopoulos24

@mgiannopoulos24 mgiannopoulos24 commented Jan 3, 2025

Copy link
Copy Markdown
Contributor

Ποιο issue κλείνει το συγκεκριμένο PR;

Closes #471

Περιγραφή του PR

Προστέθηκε η μετάφραση του collections.abc.po.

Λίστα Εργασιών

  • Προσθήκη λέξεων στο ευρετήριο main.txt.

@mgiannopoulos24 mgiannopoulos24 requested a review from a team as a code owner January 3, 2025 16:32

@skpanagiotis skpanagiotis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Καλή δουλειά, λίγο δύσκολο κείμενο με αρκετούς όρους δύσκουλους στη μετάφραση. Έχω κάνει κάποια suggestions. Μια παρατήρηση είναι η μετάφραση της λέξης co-routine.

Comment thread library/collections.abc.po Outdated
Comment thread library/collections.abc.po Outdated
Comment thread library/collections.abc.po Outdated
Comment thread library/collections.abc.po Outdated
Comment thread library/collections.abc.po Outdated
Comment thread library/collections.abc.po Outdated
Comment thread library/collections.abc.po Outdated
Comment thread library/collections.abc.po Outdated
Comment thread library/collections.abc.po
Comment thread library/collections.abc.po Outdated
mgiannopoulos24 and others added 12 commits January 8, 2025 16:56
Co-authored-by: Panagiotis Skias <panagiotis.skias@gmail.com>
Co-authored-by: Panagiotis Skias <panagiotis.skias@gmail.com>
Co-authored-by: Panagiotis Skias <panagiotis.skias@gmail.com>
Co-authored-by: Panagiotis Skias <panagiotis.skias@gmail.com>
Co-authored-by: Panagiotis Skias <panagiotis.skias@gmail.com>
Co-authored-by: Panagiotis Skias <panagiotis.skias@gmail.com>
Co-authored-by: Panagiotis Skias <panagiotis.skias@gmail.com>
Co-authored-by: Panagiotis Skias <panagiotis.skias@gmail.com>
Co-authored-by: Panagiotis Skias <panagiotis.skias@gmail.com>
Co-authored-by: Panagiotis Skias <panagiotis.skias@gmail.com>
Co-authored-by: Panagiotis Skias <panagiotis.skias@gmail.com>
@mgiannopoulos24

Copy link
Copy Markdown
Contributor Author

Να αλλάξω όλα τα co routines σε συρρουτίνες;

@skpanagiotis

Copy link
Copy Markdown
Collaborator

Προσωπικά, δεν μου κολλάει και τόσο το συρρουτίνες. Επειδή ο όρος routine και συνεπώς coroutine είναι όροι της Python θα έλεγα μήπως το αφήναμε έτσι.

@mgiannopoulos24

Copy link
Copy Markdown
Contributor Author

Εντάξει θα τα αφήσω όλα coroutines.

@skpanagiotis skpanagiotis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Κάποια κενά που έχουν ξεφύγει. Κατά τα άλλα lgtm.

Comment thread library/collections.abc.po Outdated
Comment thread library/collections.abc.po Outdated
Comment thread library/collections.abc.po Outdated
Comment thread library/collections.abc.po Outdated
mgiannopoulos24 and others added 4 commits January 11, 2025 00:16
Co-authored-by: Panagiotis Skias <panagiotis.skias@gmail.com>
Co-authored-by: Panagiotis Skias <panagiotis.skias@gmail.com>
Co-authored-by: Panagiotis Skias <panagiotis.skias@gmail.com>
Co-authored-by: Panagiotis Skias <panagiotis.skias@gmail.com>
@mgiannopoulos24

Copy link
Copy Markdown
Contributor Author

Νόμιζα ότι το powrap τα κόβει, αλλά μάλλον όχι.

@skpanagiotis

skpanagiotis commented Jan 15, 2025

Copy link
Copy Markdown
Collaborator

Θα το κάνω άλλο ένα review, αν και θα ήθελα να το κάνεις και κάποιος άλλο, και θα γίνει approve για να κλείσει. Πάντως μπράβο δύσκολο αρχείο 🎉

@gmargaritis gmargaritis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Πολύ καλή δουλεία 🤘

Αφήνω μερικές προτάσεις, LGTM overall!

Comment thread library/collections.abc.po Outdated
Comment thread library/collections.abc.po Outdated
Comment thread library/collections.abc.po
Comment thread library/collections.abc.po Outdated
Comment thread library/collections.abc.po Outdated
Comment thread library/collections.abc.po Outdated
Comment thread library/collections.abc.po Outdated
Comment thread library/collections.abc.po Outdated
mgiannopoulos24 and others added 4 commits January 15, 2025 16:26
Co-authored-by: George Margaritis <gmargaritis@protonmail.com>
Co-authored-by: George Margaritis <gmargaritis@protonmail.com>
Co-authored-by: George Margaritis <gmargaritis@protonmail.com>
Comment thread dictionaries/main.txt Outdated
mgiannopoulos24 and others added 4 commits January 15, 2025 17:23
Co-authored-by: George Margaritis <gmargaritis@protonmail.com>
Co-authored-by: Panagiotis Skias <panagiotis.skias@gmail.com>
@skpanagiotis

Copy link
Copy Markdown
Collaborator

Προτείνω να γίνει merge το συγκεκριμένο PR.

@mgiannopoulos24

Copy link
Copy Markdown
Contributor Author

@skpanagiotis δεν έχω κάνει resolve όλες τις αλλαγές που θέλετε. Δεν ξέρω αν τελικά θέλετε να τα αφήσω mutable ή να τα αλλάξω σε μεταβλητά. Πείτε μου αυτό μόνο για να τα κάνω resolve.

@gmargaritis gmargaritis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍰

@skpanagiotis skpanagiotis merged commit b413765 into python:3.12 Jan 20, 2025
@mgiannopoulos24 mgiannopoulos24 deleted the translate/library-collections-abc branch January 22, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[3.12] Translate library/collections.abc.po

3 participants