Skip to content

feat: completed the whatsnew section of the tutorial#35

Merged
raulcd merged 12 commits into
3.7from
claudia_dev_py37
May 5, 2020
Merged

feat: completed the whatsnew section of the tutorial#35
raulcd merged 12 commits into
3.7from
claudia_dev_py37

Conversation

@clacri

@clacri clacri commented May 3, 2020

Copy link
Copy Markdown
Contributor

He completado la sección what's now.

Comment thread .gitignore Outdated
*.py[cod]

# .mo files
*.mo

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Este está arriba, en la primera línea. No sé porqué no te los estaba detectando 🤷‍♂️

@raulcd raulcd self-requested a review May 3, 2020 11:15

@raulcd raulcd left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creo que Claudia quería hacer unos cambios después de pasar pospell, verdad?

@clacri

clacri commented May 3, 2020

Copy link
Copy Markdown
Contributor Author

vale, si, queria hacer un par de cambios. Pero ahora me sale un conflicto. Me lo miro

Comment thread tutorial/whatnow.po Outdated
"Content-Type: text/plain; charset=UTF-8\n"
"Content-Transfer-Encoding: 8bit\n"
"Last-Translator: \n"
"Language-Team: \n"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me parece que aquí va a diferir con el trabajo realizado en #41

Sería bueno hacer un script para actualizar antes de subir?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eamanu deberiamos tener un check que se fije que ese campo está actualizado o si podemos automatizar el cambio mejor. Queres armarte un issue y seguirlo?

@clacri cuando puedas por favor hacete un fix de esto (copiando lo que tienen los otros files) y ya podemos mergear este PR

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

creo (espero) que ahora debería estar correcto :)

Comment thread tutorial/whatnow.po Outdated
"Content-Type: text/plain; charset=UTF-8\n"
"Content-Transfer-Encoding: 8bit\n"
"Last-Translator: \n"
"Language-Team: \n"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eamanu deberiamos tener un check que se fije que ese campo está actualizado o si podemos automatizar el cambio mejor. Queres armarte un issue y seguirlo?

@clacri cuando puedas por favor hacete un fix de esto (copiando lo que tienen los otros files) y ya podemos mergear este PR

@raulcd raulcd merged commit e244025 into 3.7 May 5, 2020
@raulcd raulcd deleted the claudia_dev_py37 branch May 5, 2020 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants