Create reviewers guide#550
Merged
Merged
Conversation
cmaureir
reviewed
Jul 12, 2020
cmaureir
reviewed
Jul 12, 2020
cmaureir
left a comment
cmaureir
left a comment
Collaborator
There was a problem hiding this comment.
Gracias por este PR @silvinabt87 :)
| Cuatro razones por las que puede fallar el *build* de Travis: | ||
| * Powrap falla | ||
| * Pospell falla | ||
| * Dict está duplicado |
Collaborator
There was a problem hiding this comment.
Suggested change
| * Dict está duplicado | |
| * Dict está duplicado |
Creo que el cambio que se quiere implementar de dict por archivo, esto ya no sería necesario.
| * Powrap falla | ||
| * Pospell falla | ||
| * Dict está duplicado | ||
| * Sphinx falla No newline at end of file |
Collaborator
There was a problem hiding this comment.
Acá habría que hacer la diferencia de los warnings, y los errores que a veces hay.
Contributor
|
Yo creo que es muy buen comienzo, para mí si incluyes las sugerencias de Cristian yo haría merge ya de este PR y luego se puede mejorar pero al menos tenemos ya una pequeña introducción y un recuros para que la agente se anime con los PR, que tenemos muuuchos :) La dejo aprobada también, avisadme para mergear si quereis una vez incluidos esos cambios. |
clacri
approved these changes
Jul 20, 2020
Co-authored-by: Cristián Maureira-Fredes <cmaureir@users.noreply.github.com>
Co-authored-by: Cristián Maureira-Fredes <cmaureir@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR creates an initial reviewers guide to be updated and modified by other reviewers with tips/guidance.
Closes #399