Skip to content

Fix reference to PEP 238 in library/__future__.po translation - #1176

Merged
christopheNan merged 1 commit into
python:3.8from
matheusportela:fix-issue-39861
Mar 6, 2020
Merged

Fix reference to PEP 238 in library/__future__.po translation#1176
christopheNan merged 1 commit into
python:3.8from
matheusportela:fix-issue-39861

Conversation

@matheusportela

Copy link
Copy Markdown

As explained in https://bugs.python.org/issue39861, a typo in the French translation of library/__future__.po makes the wrong reference to PEP 328 instead of PEP 238.

I'm not sure if I followed the correct contributing guidelines since I'm not fluent in French. Let me know if I need to take further action to fix this minor bug.

@matheusportela matheusportela changed the title Fix reference to PEP in translation Fix reference to PEP 238 in library/__future__.po translation Mar 6, 2020

@vpoulailleau vpoulailleau left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For bigger modifications, we usually open an issue to avoid that several people work on the same thing at the same time (more details here in French: https://github.com/python/python-docs-fr/blob/3.8/CONTRIBUTING.rst)

But for such a small (but important) modification, it's OK to just do the PR.

Thanks.

BTW, it's the first time I see a PR correcting a bug in BPO, I don't know the process to close the issue there.

@christopheNan
christopheNan merged commit 5c511cb into python:3.8 Mar 6, 2020
@christopheNan

Copy link
Copy Markdown
Contributor

Merci pour cette correction.

@matheusportela

Copy link
Copy Markdown
Author

Got it. I'll make sure to open an issue in the future.
@vpoulailleau @christopheNan thanks for your help.

@matheusportela
matheusportela deleted the fix-issue-39861 branch March 6, 2020 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants