Skip to content

Traduction FR de la bibliothèque library/bz2.po#818

Merged
JulienPalard merged 35 commits into
python:3.8from
hucste:lib-bz2
Feb 1, 2020
Merged

Traduction FR de la bibliothèque library/bz2.po#818
JulienPalard merged 35 commits into
python:3.8from
hucste:lib-bz2

Conversation

@hucste

@hucste hucste commented Jun 12, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@Seluj78 Seluj78 added awaiting changes NEED REVIEWER This PR needs a reviewer :) and removed NEED REVIEWER This PR needs a reviewer :) awaiting changes labels Jun 15, 2019
Comment thread library/bz2.po Outdated
Comment thread library/bz2.po Outdated
Comment thread library/bz2.po Outdated
Comment thread library/bz2.po Outdated
Comment thread library/bz2.po Outdated
Comment thread library/bz2.po Outdated
Comment thread library/bz2.po Outdated
Comment thread library/bz2.po Outdated
Comment thread library/bz2.po Outdated
Comment thread library/bz2.po Outdated
@JulienPalard JulienPalard added awaiting changes and removed NEED REVIEWER This PR needs a reviewer :) labels Jul 3, 2019
@Seluj78

Seluj78 commented Oct 9, 2019

Copy link
Copy Markdown
Collaborator

@hucste ping sur les derniers conflicts ?

christopheNan
christopheNan previously approved these changes Oct 13, 2019

@christopheNan christopheNan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Très bon travail, merci !

@JulienPalard

Copy link
Copy Markdown
Member

Quelques erreurs remontées pas hunspell :

library/bz2.po:26:bzip2.
library/bz2.po:74:bzip2
library/bz2.po:253:multiflux.
library/bz2.po:332:multiflux
library/bz2.po:452:multiflux.

@JulienPalard JulienPalard left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest syntax.

Comment thread library/bz2.po Outdated

@JulienPalard JulienPalard left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remontée par travis aussi, et qq soucis de correcteur d'orthographe:

$ pospell -p dict -l fr_FR **/*.po
library/bz2.po:26:bzip2.
library/bz2.po:74:bzip2
library/bz2.po:253:multiflux.
library/bz2.po:332:multiflux
library/bz2.po:452:multiflux.

en effet, multiflux n'a pas l'air d'exister. pour bzip2 tu peux l'ajouter au dictionnaire ou le mettre en italique dans ta traduction.

Comment thread library/bz2.po Outdated

@christopheNan christopheNan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok pour laisser « multiflux » qui semble être entré dans le langage courant/commercial, mais entre astérisques.
Juste une dernière remarque :

Comment thread library/bz2.po Outdated

@hucste hucste left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ces changements ont été pris en compte, directement par moi, après explications sur le propos. cf la dernière PR

@Seluj78

Seluj78 commented Nov 15, 2019

Copy link
Copy Markdown
Collaborator

Hello @hucste ! :D Il te reste quelsques petits changements a integret, une fois fait ping nous et opn relis/merge !

@hucste

hucste commented Nov 16, 2019

Copy link
Copy Markdown
Contributor Author

Hello @hucste ! :D Il te reste quelsques petits changements a integret, une fois fait ping nous et opn relis/merge !

Je viens de le faire.

@hucste hucste requested a review from JulienPalard November 16, 2019 13:32
@Seluj78

Seluj78 commented Nov 16, 2019

Copy link
Copy Markdown
Collaborator

@hucste Top ! Il faut que tu mette les suggestions appliquées en resolues :)

@Seluj78 Seluj78 added NEED REVIEWER This PR needs a reviewer :) and removed awaiting changes labels Nov 16, 2019
@hucste

hucste commented Nov 16, 2019

Copy link
Copy Markdown
Contributor Author

@hucste Top ! Il faut que tu mette les suggestions appliquées en resolues :)

C'est bon, là ?!

@Seluj78

Seluj78 commented Nov 16, 2019

Copy link
Copy Markdown
Collaborator

@hucste Il y a encore des suggestions ouvertes avec des discussions en cours :) Je vais relire ta PR en attendant 👌

@hucste

hucste commented Nov 16, 2019

Copy link
Copy Markdown
Contributor Author

@hucste Il y a encore des suggestions ouvertes avec des discussions en cours :) Je vais relire ta PR en attendant ok_hand

OK, à-priori, il en restait deux, que je viens de passer en résolue ! :p

Merci de ton soutien. J'apprécie ! 👍

Seluj78
Seluj78 previously approved these changes Nov 16, 2019

@Seluj78 Seluj78 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allez les dernières !

Comment thread library/bz2.po Outdated
Comment thread library/bz2.po Outdated
Comment thread library/bz2.po Outdated
Comment thread library/bz2.po Outdated
Comment thread library/bz2.po Outdated
Comment thread library/bz2.po Outdated
Comment thread library/bz2.po
Comment thread library/bz2.po Outdated
@Seluj78

Seluj78 commented Nov 17, 2019

Copy link
Copy Markdown
Collaborator

@hucste on y est presque 👌 il te manque la CI ! Il faut que tu relance un powrap et tu as des balises qui foirent :)

@hucste

hucste commented Nov 18, 2019

Copy link
Copy Markdown
Contributor Author

la CI

???
Pour le reste, je viens de faire un git pull localement sur ma station…
et je vais faire le reste :p

@hucste

hucste commented Nov 18, 2019

Copy link
Copy Markdown
Contributor Author

@hucste on y est presque ok_hand il te manque la CI ! Il faut que tu relance un powrap et tu as des balises qui foirent :)

Sauf que le powrap qui foire par le Travis CI, il foire sur un fichier que je n'ai pas modifié !!!

hucste and others added 16 commits February 1, 2020 15:50
Co-Authored-By: Christophe Nanteuil <35002064+christopheNan@users.noreply.github.com>
Co-Authored-By: Christophe Nanteuil <35002064+christopheNan@users.noreply.github.com>
Co-Authored-By: Christophe Nanteuil <35002064+christopheNan@users.noreply.github.com>
OK

Co-Authored-By: Jules Lasne (jlasne) <jlasne@student.42.fr>
OK

Co-Authored-By: Jules Lasne (jlasne) <jlasne@student.42.fr>
OK

Co-Authored-By: Jules Lasne (jlasne) <jlasne@student.42.fr>
OK

Co-Authored-By: Jules Lasne (jlasne) <jlasne@student.42.fr>
OK

Co-Authored-By: Jules Lasne (jlasne) <jlasne@student.42.fr>
OK

Co-Authored-By: Jules Lasne (jlasne) <jlasne@student.42.fr>
OK

Co-Authored-By: Jules Lasne (jlasne) <jlasne@student.42.fr>
@JulienPalard JulienPalard dismissed stale reviews from Seluj78 and christopheNan via 5781b70 February 1, 2020 14:53
@JulienPalard JulienPalard changed the base branch from 3.7 to 3.8 February 1, 2020 14:53
@JulienPalard

Copy link
Copy Markdown
Member

J'ai rebasé la branche sur la 3.8.

@JulienPalard JulienPalard reopened this Feb 1, 2020
JulienPalard
JulienPalard previously approved these changes Feb 1, 2020
@JulienPalard JulienPalard merged commit ee5a8a0 into python:3.8 Feb 1, 2020
@JulienPalard

Copy link
Copy Markdown
Member

@hucste merci pour cette PR :) La CI passait super proprement une fois rebasée sur la 3.8, cool !

@hucste hucste deleted the lib-bz2 branch February 1, 2020 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants