Skip to content

working on library/ssl.po - #829

Merged
deronnax merged 12 commits into
python:3.8from
svngoku:ssl
Apr 1, 2020
Merged

working on library/ssl.po#829
deronnax merged 12 commits into
python:3.8from
svngoku:ssl

Conversation

@svngoku

@svngoku svngoku commented Jun 20, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@christopheNan christopheNan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci pour cette bonne contribution.
Je te conseille de lire les règles typographiques liées à la ponctuation et de refaire une passe. Il y a des espaces avant les ponctuations.

Comment thread library/ssl.po Outdated
Comment thread library/ssl.po Outdated
Comment thread library/ssl.po Outdated
Comment thread library/ssl.po Outdated
Comment thread library/ssl.po
Comment thread library/ssl.po Outdated
Comment thread library/ssl.po Outdated
Comment thread library/ssl.po Outdated
Comment thread library/ssl.po Outdated
Comment thread library/ssl.po Outdated
@svngoku

svngoku commented Jun 24, 2019

Copy link
Copy Markdown
Contributor Author

Merci pour le super retour . 👍

@christopheNan

Copy link
Copy Markdown
Contributor

Merci d'avoir pris en compte les remarques.
Maintenant, tu peux examiner le retour de Travis qui t'indique quelques erreurs :
clique ci-dessous sur le lien "Détails" à droite de "continuous-integration/travis-ci/pr" et regarde les lignes :

  • 269 : powrap conclut que les fichiers sont correctement alignés (ils ne dépassent pas 80 colonnes)
  • 271 à 290 : pospell indique qu'il y a plusieurs mots non reconnus et des erreurs de formatage RST.

@JulienPalard

Copy link
Copy Markdown
Member

ping @svngoku

@svngoku

svngoku commented Aug 15, 2019

Copy link
Copy Markdown
Contributor Author

1 packets transmitted, 1 received, 0% packet loss, time 11015ms 👍

@svngoku

svngoku commented Aug 15, 2019

Copy link
Copy Markdown
Contributor Author

Bonsoir @christopheNan , j'ai une petite question concernant l'expressions cipher string .
Comment pourrais-je la définir ?

Merci bien 👍

@christopheNan

christopheNan commented Aug 15, 2019 via email

Copy link
Copy Markdown
Contributor

@svngoku

svngoku commented Aug 16, 2019

Copy link
Copy Markdown
Contributor Author

@christopheNan Merci beaucoup pour le retour ✔ .

@Seluj78

Seluj78 commented Oct 9, 2019

Copy link
Copy Markdown
Collaborator

@svngoku Hello, petit ping ? 🏓

Comment thread library/ssl.po Outdated
Comment thread library/ssl.po Outdated
Comment thread library/ssl.po Outdated
Comment thread library/ssl.po Outdated
Comment thread library/ssl.po Outdated
Comment thread library/ssl.po Outdated
Comment thread library/ssl.po Outdated
Comment thread library/ssl.po Outdated
Comment thread library/ssl.po Outdated
Comment thread library/ssl.po Outdated
@svngoku

svngoku commented Oct 16, 2019

Copy link
Copy Markdown
Contributor Author

Merciii pour le retour @JulienPalard

@Seluj78

Seluj78 commented Nov 15, 2019

Copy link
Copy Markdown
Collaborator

Hello @svngoku ! Il suffit maintenant que tu accepte les suggestions (https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/incorporating-feedback-in-your-pull-request) et que tu résoude le pb de la CI ! :D

@Seluj78 Seluj78 changed the title working on ssl working on library/ssl.po Nov 17, 2019
@JulienPalard
JulienPalard changed the base branch from 3.7 to 3.8 February 1, 2020 15:21
@JulienPalard

Copy link
Copy Markdown
Member

J'ai rebasé cette PR sur la 3.8.

@JulienPalard JulienPalard reopened this Feb 1, 2020
@svngoku

svngoku commented Feb 3, 2020

Copy link
Copy Markdown
Contributor Author

Merci @JulienPalard

Est-il possible d'avoir la procédure concernant l'utilisation powrap dans le Wiki ?

@JulienPalard

Copy link
Copy Markdown
Member

Il y en a quelques mentions ici : https://github.com/python/python-docs-fr/blob/3.8/CONTRIBUTING.rst

Si tu utilise poedit tu ne devrais pas avoir besoin de powrap.

@svngoku

svngoku commented Mar 21, 2020

Copy link
Copy Markdown
Contributor Author

Salut @deronnax , oui oui je me sens pret à poursuivre.

@deronnax deronnax left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je t'ai suggéré quelques changements ;)
intègre tout d'un coup en allant dans l'onglet files changed et sur chaque remarque add suggestion to batch et ensuite commit batch à la fin.
N'oublie pas de rewrap à la fin.
Si tu bloques sur d'autres étapes, on peut le faire à ta place

Comment thread library/ssl.po Outdated
Comment thread library/ssl.po Outdated
Comment thread library/ssl.po Outdated
Comment thread library/ssl.po Outdated
Comment thread library/ssl.po Outdated
Comment thread library/ssl.po Outdated
Comment thread library/ssl.po Outdated
Comment thread library/ssl.po Outdated
Comment thread library/ssl.po Outdated
Comment thread library/ssl.po Outdated
@deronnax deronnax linked an issue Mar 21, 2020 that may be closed by this pull request
@deronnax

Copy link
Copy Markdown
Collaborator

je la reprends

@deronnax deronnax assigned deronnax and unassigned svngoku and christopheNan Mar 29, 2020
@deronnax deronnax closed this Mar 30, 2020
@deronnax deronnax reopened this Mar 30, 2020
deronnax
deronnax previously approved these changes Mar 31, 2020

@christopheNan christopheNan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quelques petits points, dont un que je remonte upstream.

Comment thread library/ssl.po Outdated
Comment thread library/ssl.po Outdated
Comment thread library/ssl.po
Comment thread library/ssl.po Outdated
Comment thread library/ssl.po Outdated
Comment thread library/ssl.po Outdated
Comment thread library/ssl.po Outdated
Comment thread library/ssl.po Outdated
Comment thread library/ssl.po Outdated
Comment thread library/ssl.po Outdated
Co-Authored-By: Christophe Nanteuil <35002064+christopheNan@users.noreply.github.com>
christopheNan
christopheNan previously approved these changes Mar 31, 2020
@deronnax
deronnax dismissed stale reviews from christopheNan via e660e86 April 1, 2020 07:18
@deronnax

deronnax commented Apr 1, 2020

Copy link
Copy Markdown
Collaborator

Alors j'ai traduit "totaly broken" par "totalement defectueux", mais je pense qu'en fait "totalement deficient" serait plus juste : https://www.larousse.fr/dictionnaires/francais/d%C3%A9ficient/22671

@christopheNan ?

@christopheNan

christopheNan commented Apr 1, 2020 via email

Copy link
Copy Markdown
Contributor

@deronnax

deronnax commented Apr 1, 2020

Copy link
Copy Markdown
Collaborator

des fois je te laisse des questions en commentaire, qui ne sont pas des suggestions de code, mais tu n'y répond jamais (lors que ça n'est pas des suggestions de code) 😢
Capture d’écran 2020-04-01 à 20 33 10

@deronnax
deronnax dismissed JulienPalard’s stale review April 1, 2020 20:57

tous les points ont été traités + Julien pas dispo ATM

@deronnax
deronnax merged commit e51ec9a into python:3.8 Apr 1, 2020
@deronnax

deronnax commented Apr 1, 2020

Copy link
Copy Markdown
Collaborator

Hop c'est fusionné. Merci @svngoku ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Je travaille sur library/ssl.po

5 participants