Translate c-api/refcounting.po#559
Merged
Merged
Conversation
Collaborator
Author
|
@rockleona Please help review this PR when you're available. Thanks! |
rockleona
reviewed
Aug 7, 2023
rockleona
reviewed
Aug 7, 2023
rockleona
reviewed
Aug 7, 2023
Comment on lines
+257
to
+258
| "這會在減少 `dst` 舊值的參照計數\\ _之前_\\ 將 `dst` 設定為 `src`，使得因 " | ||
| "`dst` 被拆除而觸發的任何程式碼不會相信 `dst` 有指向一個有效物件。" |
Collaborator
There was a problem hiding this comment.
這句好難喔@@
我修改了一下語句看有沒有比較通順
Suggested change
| "這會在減少 `dst` 舊值的參照計數\\ _之前_\\ 將 `dst` 設定為 `src`，使得因 " | |
| "`dst` 被拆除而觸發的任何程式碼不會相信 `dst` 有指向一個有效物件。" | |
| "這會在減少 `dst` 舊值的參照計數\\ _之前_\\ 將 `dst` 設定為 `src`，使得任何程式碼 " | |
| "觸發了 `dst` 被拆除的副作用 (side-effect) 進而不會相信 `dst` 有指向一個有效物件。" |
Collaborator
Author
|
想麻煩 @rockleona 參與 #568 的討論，一起幫忙看看這樣變更會不會有什麼問題 🙏🏽 |
Collaborator
|
好的，我待會來去看看 |
mattwang44
commented
Aug 11, 2023
Comment on lines
+257
to
+258
| "這會在減少 `dst` 舊值的參照計數\\ _之前_\\ 將 `dst` 設定為 `src`，使得因 " | ||
| "`dst` 被拆除而觸發的任何程式碼不會相信 `dst` 有指向一個有效物件。" |
Collaborator
Author
There was a problem hiding this comment.
- code 指的應該是被意外觸發的部分（也就是 side effect）
- 我漏翻 side effect
如果改成這樣呢？
Suggested change
| "這會在減少 `dst` 舊值的參照計數\\ _之前_\\ 將 `dst` 設定為 `src`，使得因 " | |
| "`dst` 被拆除而觸發的任何程式碼不會相信 `dst` 有指向一個有效物件。" | |
| "這會在減少 `dst` 舊值的參照計數\\ _之前_\\ 將 `dst` 設定為 `src`，使得因 " | |
| "`dst` 被拆除而觸發的任何副作用 (side-effect) 之程式碼不會相信 `dst` 是" | |
| "指向一個有效物件。" |
Collaborator
Author
|
c-api/refcounting 原文近期有不少變動，最近會再找時間補上這個 PR |
Collaborator
Author
已補 |
rockleona
reviewed
Aug 16, 2023
rockleona
reviewed
Aug 16, 2023
rockleona
reviewed
Aug 16, 2023
rockleona
left a comment
rockleona
left a comment
Collaborator
There was a problem hiding this comment.
看完一輪之後只能說請收下我的膝蓋吧(X)
太精準了!
beccalzh
pushed a commit
to beccalzh/python-docs-zh-tw
that referenced
this pull request
Sep 4, 2024
* translate `c-api/refcounting.po` * fix: updated the source strings and their translations * fix(c-api/refcounting): modify based on review comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
translate some strings that are newly-added in 3.12 doc
preview